Merge pull request #286 from thecodingmachine/fix-count-on-iterator-take

nguyenk · web-flow · commit 21cc4cc27ede · 2024-05-15T18:28:38.000+02:00
fix issue in result iteratornow that total_count is not been initialized
diff --git a/src/ResultIterator.php b/src/ResultIterator.php
@@ -184,7 +184,7 @@ public function getIterator()
      */
     public function take($offset, $limit)
     {
-        if ($this->totalCount === 0) {
+        if ($this instanceof EmptyResultIterator) {
             return PageIterator::createEmpyIterator($this);
         }
         return PageIterator::createResultIterator($this, $this->queryFactory->getMagicSql(), $this->parameters, $limit, $offset, $this->queryFactory->getColumnDescriptors(), $this->objectStorage, $this->className, $this->tdbmService, $this->magicQuery, $this->mode, $this->logger);

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ public function getIterator()`
`184`	`184`	`*/`
`185`	`185`	`public function take($offset, $limit)`
`186`	`186`	`{`
`187`		`- if ($this->totalCount === 0) {`
	`187`	`+ if ($this instanceof EmptyResultIterator) {`
`188`	`188`	`return PageIterator::createEmpyIterator($this);`
`189`	`189`	`}`
`190`	`190`	`return PageIterator::createResultIterator($this, $this->queryFactory->getMagicSql(), $this->parameters, $limit, $offset, $this->queryFactory->getColumnDescriptors(), $this->objectStorage, $this->className, $this->tdbmService, $this->magicQuery, $this->mode, $this->logger);`