fix(core): Improve private registry support (tolerate not implemented fields in DOCKER_AUTH_CONFIG) #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage ? 78.26%
=======================================
Files ? 12
Lines ? 598
Branches ? 89
=======================================
Hits ? 468
Misses ? 104
Partials ? 26 ☔ View full report in Codecov by Sentry. |
Member
|
since this does not actually implement the features i am going to merge this as a fix |
alexanderankin
pushed a commit
that referenced
this pull request
Jul 15, 2024
🤖 I have created a release *beep* *boop* --- ## [4.7.2](testcontainers-v4.7.1...testcontainers-v4.7.2) (2024-07-15) ### Bug Fixes * Add container Trino ([#642](#642)) ([49ce5a5](49ce5a5)), closes [#641](#641) * **core:** Improve private registry support (tolerate not implemented fields in DOCKER_AUTH_CONFIG) ([#647](#647)) ([766c382](766c382)) * **kafka:** add a flag to limit to first hostname for use with networks ([#638](#638)) ([0ce4fec](0ce4fec)), closes [#637](#637) * **modules:** Mailpit container base API URL helper method ([#643](#643)) ([df07586](df07586)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #562, got some feedback regarding an issue with unsupported use cases.
In this PR we will try to:
DOCKER_AUTH_CONFIGleads to an errorAs always any feedback will be much appreciated.
Please note this PR does not implement all use-cases just does a better job at preparing and handling them for now