Support docker context when using autoIgnoringUserProperties #7178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With docker-java/docker-java#2130 being merged and release, it would be lovely to get this one merged and releases |
mattcoleanderson
approved these changes
Jul 11, 2023
|
kindly reminder, could we get it this merged? |
|
Thanks for submitting the PR, @piotrwielgolaski-tomtom ! However, after a internal discussion we need to review and talk about how to support it cross languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enable support for docker context
I used existing option of
dockerconfig.source=autoIgnoringUserPropertieswhen this option is enabled, it use docker-java configuration that is aware of context already
This PR requires fix from docker docker-java/docker-java#2130 to support TLS in context, other use cases could work without this fix.