8000 Merge pull request #261 from bpierre/contribution-guide · terrierscript/vue@5fb8b10 · GitHub
[go: up one dir, main page]
Skip to content

Commit 5fb8b10

Browse files
yyx990803yyx990803
committed
Merge pull request vuejs#261 from bpierre/contribution-guide
Contributing guide update
2 parents 8cd19f0 + 04a7ff6 commit 5fb8b10

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

‎CONTRIBUTING.md

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
# Vue.js Contributing Guide
22

3-
Hi! I'm really excited that you are interested in contributing to Vue.js. Before submitting a pull request though, please make sure to take a moment and read through the following guidelines.
3+
Hi! I’m really excited that you are interested in contributing to Vue.js. Before submitting your contribution though, please make sure to take a moment and read through the following guidelines.
4+
5+
## Issue Reporting Checklist
6+
7+
- Make sure that you are using the latest version of Vue.
8+
- Try to search for your issue, it may have already been answered or even fixed in the development branch.
9+
- It is recommended that you make a JSFiddle to reproduce your issue. You could start with [this template](http://jsfiddle.net/5sH6A/) that already includes the latest version of Vue.
10+
- If your issue is resolved but still open, don’t hesitate to close it. In case you found a solution by yourself, it could be helpful to explain how you fixed it.
411

512
## Pull Request Checklist
613

@@ -36,7 +43,7 @@ var a = superLongConditionalStatement
3643
You will need [Node](http://nodejs.org), [Grunt](http://gruntjs.com), [PhantomJS](http://phantomjs.org) and [CasperJS](http://casperjs.org).
3744

3845
``` bash
39-
# in case you don't already it:
46+
# in case you don’t already it:
4047
# npm install -g grunt-cli
4148
$ npm install
4249
```
@@ -62,7 +69,7 @@ $ grunt build
6269
To test:
6370

6471
``` bash
65-
# if you don't have these yet:
72+
# if you don’t have these yet:
6673
# npm install -g phantomjs casperjs
6774
$ grunt test
6875
```
@@ -71,4 +78,4 @@ The unit tests are written with Mocha + Chai and run with Karma. The functional
7178

7279
**If you are not using a Mac**
7380

74-
You can modify the Gruntfile to only run Karma tests in browsers that are available on your system. Just make sure don't check in the Gruntfile for the commit.
81+
You can modify the Gruntfile to only run Karma tests in browsers that are available on your system. Just make sure don’t check in the Gruntfile for the commit.

0 commit comments

Comments
 (0)
0