Fixed|Changed(SmsInboxAPI)!: Fix exception for message address/from selection and use exact match

agnostic-apollo · agnostic-apollo · commit 12e7b6513b38 · 2025-01-26T00:54:50.000+05:00
SQL does not seem to consider `?` placeholders if inside quotes. ``` java.lang.IllegalArgumentException: Cannot bind argument at index 1 because the index is out of range. The statement has 0 parameters. at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:172) at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:142) at android.content.ContentProviderProxy.query(ContentProviderNative.java:472) at android.content.ContentResolver.query(ContentResolver.java:1183) at android.content.ContentResolver.query(ContentResolver.java:1115) at android.content.ContentResolver.query(ContentResolver.java:1071) at com.termux.api.apis.SmsInboxAPI.getAllSms(SmsInboxAPI.java:302) ``` Exact match is used by default so that only exactly matched entries are returned, users can use `%` wildcards in the address passed if they want to do prefix/contains/suffix matching. - https://www.w3schools.com/sql/sql_like.asp
diff --git a/app/src/main/java/com/termux/api/apis/SmsInboxAPI.java b/app/src/main/java/com/termux/api/apis/SmsInboxAPI.java
@@ -292,7 +292,7 @@ public static void getAllSms(Context context, JsonWriter out,
         String[] messageSelectionArgs = null;
         if (messageSelection == null || messageSelection.isEmpty()) {
             if (messageAddress != null && !messageAddress.isEmpty()) {
-                messageSelection = ADDRESS + " LIKE '%?%'";
+                messageSelection = ADDRESS + " LIKE ?";
                 messageSelectionArgs = new String[]{messageAddress};
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ public static void getAllSms(Context context, JsonWriter out,`
`292`	`292`	`String[] messageSelectionArgs = null;`
`293`	`293`	`if (messageSelection == null \|\| messageSelection.isEmpty()) {`
`294`	`294`	`if (messageAddress != null && !messageAddress.isEmpty()) {`
`295`		`- messageSelection = ADDRESS + " LIKE '%?%'";`
	`295`	`+ messageSelection = ADDRESS + " LIKE ?";`
`296`	`296`	`messageSelectionArgs = new String[]{messageAddress};`
`297`	`297`	`}`
`298`	`298`	`}`