Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed

kalessil · kalessil · commit e1773ee2b8e9 · 2017-03-03T17:35:37.000+01:00
diff --git a/src/Symfony/Component/Intl/DateFormatter/DateFormat/TimeZoneTransformer.php b/src/Symfony/Component/Intl/DateFormatter/DateFormat/TimeZoneTransformer.php
@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)
             return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');
         }
 
-        throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');
+        throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));
     }
 }
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -162,7 +162,6 @@ public function __construct($commandline, $cwd = null, array $env = null, $input
         $this->setTimeout($timeout);
         $this->useFileHandles = '\\' === DIRECTORY_SEPARATOR;
         $this->pty = false;
-        $this->enhanceWindowsCompatibility = true;
         $this->enhanceSigchildCompatibility = '\\' !== DIRECTORY_SEPARATOR && $this->isSigchildEnabled();
         $this->options = array_replace(array('suppress_errors' => true, 'binary_pipes' => true), $options);
     }
diff --git a/src/Symfony/Component/Security/Http/Firewall/DigestAuthenticationListener.php b/src/Symfony/Component/Security/Http/Firewall/DigestAuthenticationListener.php
@@ -206,7 +206,7 @@ public function calculateServerDigest($password, $httpMethod)
         } elseif ('auth' === $this->elements['qop']) {
             $digest .= ':'.$this->elements['nc'].':'.$this->elements['cnonce'].':'.$this->elements['qop'];
         } else {
-            throw new \InvalidArgumentException('This method does not support a qop: "%s".', $this->elements['qop']);
+            throw new \InvalidArgumentException(sprintf('This method does not support a qop: "%s".', $this->elements['qop']));
         }
         $digest .= ':'.$a2Md5;
 
diff --git a/src/Symfony/Component/Translation/Catalogue/AbstractOperation.php b/src/Symfony/Component/Translation/Catalogue/AbstractOperation.php
@@ -61,7 +61,6 @@ public function __construct(MessageCatalogueInterface $source, MessageCatalogueI
         $this->source = $source;
         $this->target = $target;
         $this->result = new MessageCatalogue($source->getLocale());
-        $this->domains = null;
         $this->messages = array();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)`
`94`	`94`	`return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');`
`95`	`95`	`}`
`96`	`96`
`97`		`- throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');`
	`97`	`+ throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));`
`98`	`98`	`}`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,6 @@ public function __construct($commandline, $cwd = null, array $env = null, $input`
`162`	`162`	`$this->setTimeout($timeout);`
`163`	`163`	`$this->useFileHandles = '\\' === DIRECTORY_SEPARATOR;`
`164`	`164`	`$this->pty = false;`
`165`		`- $this->enhanceWindowsCompatibility = true;`
`166`	`165`	`$this->enhanceSigchildCompatibility = '\\' !== DIRECTORY_SEPARATOR && $this->isSigchildEnabled();`
`167`	`166`	`$this->options = array_replace(array('suppress_errors' => true, 'binary_pipes' => true), $options);`
`168`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ public function calculateServerDigest($password, $httpMethod)`
`206`	`206`	`} elseif ('auth' === $this->elements['qop']) {`
`207`	`207`	`$digest .= ':'.$this->elements['nc'].':'.$this->elements['cnonce'].':'.$this->elements['qop'];`
`208`	`208`	`} else {`
`209`		`- throw new \InvalidArgumentException('This method does not support a qop: "%s".', $this->elements['qop']);`
	`209`	`+ throw new \InvalidArgumentException(sprintf('This method does not support a qop: "%s".', $this->elements['qop']));`
`210`	`210`	`}`
`211`	`211`	`$digest .= ':'.$a2Md5;`
`212`	`212`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ public function __construct(MessageCatalogueInterface $source, MessageCatalogueI`
`61`	`61`	`$this->source = $source;`
`62`	`62`	`$this->target = $target;`
`63`	`63`	`$this->result = new MessageCatalogue($source->getLocale());`
`64`		`- $this->domains = null;`
`65`	`64`	`$this->messages = array();`
`66`	`65`	`}`
`67`	`66`