Refactor SymbolicMap variable replacement and dimension adjustments#112147
Draft
copybara-service[bot] wants to merge 1 commit intomasterfrom
Draft
Refactor SymbolicMap variable replacement and dimension adjustments#112147copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
We have some failing tests in IndexingMap::GetAffineMap() migration to GetSymbolicMap(). After some debugging, I found out the issue relies in SymbolicMap::Replace() method. Similar to AffineMap similar one, it allowed to change the number of dimensions and symbols. But this is a problem in SymbolicMap that results in different bugs since all are mapped to the same kVariable data type. After some discussions, we decided to not allow SymbolicMap::Replace() to modify the number of dimensions and symbols and instead provide a different method for that (SetNumDimensions). I will create SetNumSymbols if needed in the future. PiperOrigin-RevId: 882030835
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor SymbolicMap variable replacement and dimension adjustments
We have some failing tests in IndexingMap::GetAffineMap() migration to GetSymbolicMap(). After some debugging, I found out the issue relies in SymbolicMap::Replace() method. Similar to AffineMap similar one, it allowed to change the number of dimensions and symbols. But this is a problem in SymbolicMap that results in different bugs since all are mapped to the same kVariable data type.
After some discussions, we decided to not allow SymbolicMap::Replace() to modify the number of dimensions and symbols and instead provide a different method for that (SetNumDimensions). I will create SetNumSymbols if needed in the future.