[XLA:GPU] Pre-process layouts in GemmConfig::For.#112134
Draft
copybara-service[bot] wants to merge 1 commit intomasterfrom
Draft
[XLA:GPU] Pre-process layouts in GemmConfig::For.#112134copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
a64be2d to
d3e35a8
Compare
This addresses a TODO in GetMatrixDescriptors to avoid re-calculating the column-major layouts and swapping operands on every call. The original layouts are preserved in the GemmConfig base class to maintain compatibility with other users (like GemmThunk::buffer_uses), while the processed layouts for BLAS are stored in new members. This also resolves shadowing warnings in GemmConfig::For parameters. PiperOrigin-RevId: 882000820
d3e35a8 to
3ccbb69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Pre-process layouts in GemmConfig::For.
This addresses a TODO in GetMatrixDescriptors to avoid re-calculating the
column-major layouts and swapping operands on every call.
The original layouts are preserved in the GemmConfig base class to maintain
compatibility with other users (like GemmThunk::buffer_uses), while the
processed layouts for BLAS are stored in new members.
This also resolves shadowing warnings in GemmConfig::For parameters.