8000 NonRootNamespaceAutoConfiguration#nonRootBeanPostProcessor breaks MeterRegistry customizations · Issue #2533 · temporalio/sdk-java · GitHub
[go: up one dir, main page]

Skip to content
NonRootNamespaceAutoConfiguration#nonRootBeanPostProcessor breaks MeterRegistry customizations #2533
@rpost

Description

@rpost

Expected Behavior

Exposed metrics are filtered according to defined MeterRegistryCustomizer.

Actual Behavior

io.temporal.spring.boot.autoconfigure.NonRootNamespaceAutoConfiguration#nonRootBeanPostProcessor causes early initialization of MeterRegistry (through io.temporal.spring.boot.autoconfigure.MetricsScopeAutoConfiguration#scope), even before org.springframework.boot.actuate.autoconfigure.metrics.MeterRegistryPostProcessor is ready. This makes
any MeterRegistryCustomizer effectively ignored.

Steps to Reproduce the Problem

I prepared small reproducer project: https://github.com/rpost/temporal-bug:

  1. rpost/temporal-bug@d97d735 introduces setup and adds test which proves metrics being filtered accordingly.
  2. rpost/temporal-bug@0a77f4a adds temporal client and this makes test broken
  3. rpost/temporal-bug@d16476e contains workaround

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0