Fix unit tests on Windows

rosen-vladimirov · rosen-vladimirov · commit 80fe24c09c58 · 2017-11-01T09:41:25.000+02:00
Currently unit tests fail on Windows as the `type` command used in the tests is not a real executable - it is integrated in the `cmd`. So spawning `type` fails and the tests fail as well.
In order to fix this, pass `shell` option to child process, so the child process will spawn CMD and after that type command will succeed.
diff --git a/test/unit-tests/mobile/android/logcat-helper.ts b/test/unit-tests/mobile/android/logcat-helper.ts
@@ -11,14 +11,17 @@ class ChildProcessStub {
 	public spawn(command: string, args?: string[], options?: any): childProcess.ChildProcess {
 		ChildProcessStub.methodCallCount++;
 		let pathToExecutable = "";
+		let shell = "";
 		if (this.isWin) {
 			pathToExecutable = "type";
+			shell = "cmd";
 		} else {
 			pathToExecutable = "cat";
 		}
 		pathToExecutable = path.join(pathToExecutable);
 		const pathToSample = path.join(__dirname, "valid-sample.txt");
-		return childProcess.spawn(pathToExecutable, [pathToSample]);
+
+		return childProcess.spawn(pathToExecutable, [pathToSample], { shell });
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11,14 +11,17 @@ class ChildProcessStub {`
`11`	`11`	`public spawn(command: string, args?: string[], options?: any): childProcess.ChildProcess {`
`12`	`12`	`ChildProcessStub.methodCallCount++;`
`13`	`13`	`let pathToExecutable = "";`
	`14`	`+ let shell = "";`
`14`	`15`	`if (this.isWin) {`
`15`	`16`	`pathToExecutable = "type";`
	`17`	`+ shell = "cmd";`
`16`	`18`	`} else {`
`17`	`19`	`pathToExecutable = "cat";`
`18`	`20`	`}`
`19`	`21`	`pathToExecutable = path.join(pathToExecutable);`
`20`	`22`	`const pathToSample = path.join(__dirname, "valid-sample.txt");`
`21`		`- return childProcess.spawn(pathToExecutable, [pathToSample]);`
	`23`	`+`
	`24`	`+ return childProcess.spawn(pathToExecutable, [pathToSample], { shell });`
`22`	`25`	`}`
`23`	`26`	`}`
`24`	`27`