8000 fix: Use Class.id internally (#1674) · tallarium/sentry-javascript@65965ff · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Feb 8, 2020. It is now read-only.

Commit 65965ff

Browse files
HazATHazAT
authored
fix: Use Class.id internally (getsentry#1674)
* fix: Use Class.id internally * meta: Add changelog
1 parent e6da9a9 commit 65965ff

File tree

23 files changed

+35
-25
lines changed

23 files changed

+35
-25
lines changed

‎CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# Changelog
22

33
## Unreleased
4+
## 4.2.2
5+
6+
- [core]: "De-deprecate" name of `Integration` interface.
47

58
## 4.2.1
69

‎packages/browser/src/integrations/breadcrumbs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export class Breadcrumbs implements Integration {
3838
/**
3939
* @inheritDoc
4040
*/
41-
public name: string = 'Breadcrumbs';
41+
public name: string = Breadcrumbs.id;
4242

4343
/**
4444
* @inheritDoc

‎packages/browser/src/integrations/globalhandlers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export class GlobalHandlers implements Integration {
2121
/**
2222
* @inheritDoc
2323
*/
24-
public name: string = 'GlobalHandlers';
24+
public name: string = GlobalHandlers.id;
2525

2626
/**
2727
* @inheritDoc

‎packages/browser/src/integrations/linkederrors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class LinkedErrors implements Integration {
1818
/**
1919
* @inheritDoc
2020
*/
21-
public readonly name: string = 'LinkedErrors';
21+
public readonly name: string = LinkedErrors.id;
2222

2323
/**
2424
* @inheritDoc

‎packages/browser/src/integrations/pluggable/ember.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export class Ember implements Integration {
77
/**
88
* @inheritDoc
99
*/
10-
public name: string = 'Ember';
10+
public name: string = Ember.id;
1111
/**
1212
* @inheritDoc
1313
*/

‎packages/browser/src/integrations/pluggable/vue.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export class Vue implements Integration {
1818
/**
1919
* @inheritDoc
2020
*/
21-
public name: string = 'Vue';
21+
public name: string = Vue.id;
2222
/**
2323
* @inheritDoc
2424
*/

‎packages/browser/src/integrations/reportingobserver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class ReportingObserver implements Integration {
5757
/**
5858
* @inheritDoc
5959
*/
60-
public readonly name: string = 'ReportingObserver';
60+
public readonly name: string = ReportingObserver.id;
6161
/**
6262
* @inheritDoc
6363
*/

‎packages/browser/src/integrations/trycatch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export class TryCatch implements Integration {
1111
/**
1212
* @inheritDoc
1313
*/
14-
public name: string = 'TryCatch';
14+
public name: string = TryCatch.id;
1515

1616
/**
1717
* @inheritDoc

‎packages/browser/src/integrations/useragent.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export class UserAgent implements Integration {
99
/**
1010
* @inheritDoc
1111
*/
12-
public name: string = 'UserAgent';
12+
public name: string = UserAgent.id;
1313

1414
/**
1515
* @inheritDoc

‎packages/core/src/integrations/dedupe.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export class Dedupe implements Integration {
1313
/**
1414
* @inheritDoc
1515
*/
16-
public name: string = 'Dedupe';
16+
public name: string = Dedupe.id;
1717

1818
/**
1919
* @inheritDoc

‎packages/core/src/integrations/functiontostring.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,13 @@ export class FunctionToString implements Integration {
77
/**
88
* @inheritDoc
99
*/
10-
public name: string = 'FunctionToString';
10+
public name: string = FunctionToString.id;
11+
12+
/**
13+
* @inheritDoc
14+
*/
15+
public static id: string = 'FunctionToString';
16+
1117
/**
1218
* @inheritDoc
1319
*/

‎packages/core/src/integrations/inboundfilters.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class InboundFilters implements Integration {
2828
/**
2929
* @inheritDoc
3030
*/
31-
public name: string = 'InboundFilters';
31+
public name: string = InboundFilters.id;
3232
/**
3333
* @inheritDoc
3434
*/

‎packages/core/src/integrations/pluggable/debug.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export class Debug implements Integration {
1212
/**
1313
* @inheritDoc
1414
*/
15-
public name: string = 'Debug';
15+
public name: string = Debug.id;
1616

1717
/**
1818
* @inheritDoc

‎packages/core/src/integrations/pluggable/rewriteframes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export class RewriteFrames implements Integration {
99
/**
1010
* @inheritDoc
1111
*/
12-
public name: string = 'RewriteFrames';
12+
public name: string = RewriteFrames.id;
1313

1414
/**
1515
* @inheritDoc

‎packages/node/src/integrations/console.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export class Console implements Integration {
88
/**
99
* @inheritDoc
1010
*/
11-
public name: string = 'Console';
11+
public name: string = Console.id;
1212
/**
1313
* @inheritDoc
1414
*/

‎packages/node/src/integrations/http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Http implements Integration {
1919
/**
2020
* @inheritDoc
2121
*/
22-
public name: string = 'Http';
22+
public name: string = Http.id;
2323
/**
2424
* @inheritDoc
2525
*/

‎packages/node/src/integrations/linkederrors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class LinkedErrors implements Integration {
1717
/**
1818
* @inheritDoc
1919
*/
20-
public readonly name: string = 'LinkedErrors';
20+
public readonly name: string = LinkedErrors.id;
2121
/**
2222
* @inheritDoc
2323
*/

‎packages/node/src/integrations/onuncaughtexception.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export class OnUncaughtException implements Integration {
88
/**
99
* @inheritDoc
1010
*/
11-
public name: string = 'OnUncaughtException';
11+
public name: string = OnUncaughtException.id;
1212
/**
1313
* @inheritDoc
1414
*/

‎packages/node/src/integrations/onunhandledrejection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export class OnUnhandledRejection implements Integration {
66
/**
77
* @inheritDoc
88
*/
9-
public name: string = 'OnUnhandledRejection';
9+
public name: string = OnUnhandledRejection.id;
1010
/**
1111
* @inheritDoc
1212
*/

‎packages/node/src/integrations/pluggable/modules.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export class Modules implements Integration {
99
/**
1010
* @inheritDoc
1111
*/
12-
public name: string = 'Modules';
12+
public name: string = Modules.id;
1313
/**
1414
* @inheritDoc
1515
*/

‎packages/node/src/integrations/pluggable/transaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export class Transaction implements Integration {
66
/**
77
* @inheritDoc
88
*/
9-
public name: string = 'Transaction';
9+
public name: string = Transaction.id;
1010
/**
1111
* @inheritDoc
1212
*/

‎packages/types/src/index.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,9 +195,8 @@ export interface Mechanism {
195195

196196
/** Integration interface */
197197
export interface Integration {
198-
// TODO: Remove with v5
199198
/**
200-
* @deprecated Use {@link IntegrationClass.id} instead
199+
* Returns {@link IntegrationClass.id}
201200
*/
202201
name: string;
203202
// TODO: Remove with v5

‎scripts/pack-and-upload.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,17 @@ yarn global add @zeus-ci/cli
55
yarn
66
yarn build
77

8-
# Sanity Check
9-
yarn lerna changed --include-merged-tags -p
10-
118
# Temp workaround
9+
############################################
1210
git clone https://github.com/HazAT/lerna.git
1311
cd lerna
1412
npm link
1513
cd ../
1614
npm link lerna
15+
16+
# Sanity Check
17+
yarn lerna changed --include-merged-tags -p
18+
1719
############################################
1820

1921
# Upload NPM packages

0 commit comments

Comments
 (0)
0