8000 [Docs] Adds docs for groups.update by shinchris · Pull Request #797 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

[Docs] Adds docs for groups.update #797

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2021
Merged

[Docs] Adds docs for groups.update #797

merged 1 commit into from
Feb 24, 2021

Conversation

shinchris
Copy link
Contributor

Goes with #772

@shinchris shinchris mentioned this pull request Feb 22, 2021
Closed
bcantoni
bcantoni requested changes Feb 24, 2021
View reviewed changes
Copy link
Contributor
@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New content looks good. I tested the sample on a couple servers.

Since we're showing how to use license_mode and minimum_site_role, I think we should add those under the GroupItem class. Under license_mode we should explain the 2 options onLogin and onSync. (Possible values for minimum_site_role are already explained under UserItem.)

@shinchris
Copy link
Contributor Author

Thanks @bcantoni!
Those were added with #771 and are live in our docs.

bcantoni
bcantoni approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor
@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's great! I had checked out this branch so I had missed it. Looks good to go.

@shinchris shinchris merged commit 6ace934 into gh-pages Feb 24, 2021
@shinchris shinchris deleted the update_group_doc branch February 24, 2021 20:56
@jacalata jacalata mentioned this pull request Nov 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcantoni bcantoni bcantoni approved these changes

@jacalata jacalata Awaiting requested review from jacalata

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinchris @bcantoni
0