10000 Improves login sample by shinchris · Pull Request #652 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Improves login sample #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Improves login sample #652

merged 2 commits into from
Jul 22, 2020

Conversation

shinchris
Copy link
Contributor
  1. Changed the default sitename argument to be an empty string - consistent with the model objects
  2. Added more print statements

@shinchris shinchris merged commit ccbbc49 into development Jul 22, 2020
@shinchris shinchris deleted the login_sample branch July 22, 2020 21:09
shinchris pushed a commit that referenced this pull request Jul 22, 2020
Fixes default sitename in login sample and adds more print statements (…
3041b4a 
…#652)

(cherry picked from commit ccbbc49)
shinchris pushed a commit that referenced this pull request Aug 14, 2020
@rshide @jorwoods @bcantoni
Added webpage url to workbooks (#661)
0133207 
* Fixes login sample to pass in sitename for username/password auth

(cherry picked from commit 4cbd800)

* Fixes default sitename in login sample and adds more print statements (#652)


(cherry picked from commit ccbbc49)

* Updates changelog with patch notes

* Added webpage_url to workbooks

* removed vscode files

* Update workbook_item.py

Removing whitespace

* Update test_workbook.py

Removing cells

* Update test_workbook.py

Removing whitespace

* Update workbook_get_by_id.xml

Adding webpage url

* Create notes property from XML response (#571)

Create notes property from XML response

Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>

* Minor edits and cleanup

* Rename a duplicate test method so they all run

* Cleanup test comments and descriptions, no functional changes

* Add support for Python 3.8

Only test_publish_with_hidden_view() needed changes because the order of
attributes in the XML request body were swapped for some reason in 3.8
compared to prior Pythons.

Co-authored-by: Chris Shin <cshin@tableau.com>
Co-authored-by: Rickey Shideler <rickey.shideler.jr@walmart.com>
Co-authored-by: jorwoods <jorwoods@users.noreply.github.com>
Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>
Co-authored-by: Brian Cantoni <bcantoni@tableau.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinchris @t8y8
0