From fb9d12ad94f830e95eb76fc1b3f89c8882cb7f00 Mon Sep 17 00:00:00 2001 From: Chris Shin Date: Mon, 15 Jul 2019 15:23:38 -0700 Subject: [PATCH] Fix update_workbook endpoint to address #454 --- tableauserverclient/server/request_factory.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py index fdc799af1..72bf90d80 100644 --- a/tableauserverclient/server/request_factory.py +++ b/tableauserverclient/server/request_factory.py @@ -382,7 +382,7 @@ def update_req(self, workbook_item): workbook_element = ET.SubElement(xml_request, 'workbook') if workbook_item.name: workbook_element.attrib['name'] = workbook_item.name - if workbook_item.show_tabs: + if workbook_item.show_tabs is not None: workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower() if workbook_item.project_id: project_element = ET.SubElement(workbook_element, 'project') @@ -390,7 +390,8 @@ def update_req(self, workbook_item): if workbook_item.owner_id: owner_element = ET.SubElement(workbook_element, 'owner') owner_element.attrib['id'] = workbook_item.owner_id - if workbook_item.materialized_views_config is not None: + if workbook_item.materialized_views_config['materialized_views_enabled']\ + and workbook_item.materialized_views_config['run_materialization_now']: materialized_views_config = workbook_item.materialized_views_config materialized_views_element = ET.SubElement(workbook_element, 'materializedViewsEnablementConfig') materialized_views_element.attrib['materializedViewsEnabled'] = str(materialized_views_config