8000 205 - Pager/Fetcher all the things! by t8y8 · Pull Request #231 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

205 - Pager/Fetcher all the things! #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 26, 2017
Merged

205 - Pager/Fetcher all the things! #231

merged 10 commits into from
Sep 26, 2017

Conversation

t8y8
Copy link
Collaborator
@t8y8 t8y8 commented Sep 23, 2017 •
edited
Loading

Here's a checkpoint PR for where I'm at in concerting all the models to 'fetch-on-demand' after you call populate_XXX on something.

Mostly it's a straight forward conversation but a few places have some interesting caveats so posting here for feedback.

EDIT: I've converted all the endpoints, I believe, so they all have on-demand fetching. WOO.

Also added test coverage where there wasn't any. This covers @grbritz's bug as well

@t8y8 t8y8 changed the title [WIP] 205 - Pager/Fetcher all the things! 205 - Pager/Fetcher all the things! Sep 23, 2017
graysonarts
graysonarts reviewed Sep 25, 2017
View reviewed changes
tableauserverclient/server/endpoint/users_endpoint.py Outdated
@@ -70,15 +70,24 @@ def add(self, user_item):
# Get workbooks for user
@api(version="2.0")
def populate_workbooks(self, user_item, req_options=None):
from .. import Pager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this here?

Copy link
Collaborator Author
@t8y8 t8y8 Sep 25, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that on the 'users-in-groups' bugfix and just copied the pattern.

Don't think there's a great reason, just how I did it before.

I can move it to a top-level import

graysonarts
graysonarts approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor
@graysonarts graysonarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t8y8 t8y8 merged commit 71ced7c into tableau:development Sep 26, 2017
@t8y8 t8y8 deleted the 205-feature-pager-all-the-things branch September 26, 2017 21:17
@t8y8 t8y8 mentioned this pull request Sep 26, 2017
Closed
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
@jacalata
hidden fields, schema and service fields (tableau#231)
753bd96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graysonarts graysonarts graysonarts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t8y8 @graysonarts
0