From 4d34a2188f54cbbffc22be13a6308d2c225d8387 Mon Sep 17 00:00:00 2001 From: T8y8 Date: Tue, 28 Mar 2017 10:43:31 -0700 Subject: [PATCH] Fix for 162 --- .../server/endpoint/groups_endpoint.py | 12 ++++++------ test/test_group.py | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tableauserverclient/server/endpoint/groups_endpoint.py b/tableauserverclient/server/endpoint/groups_endpoint.py index a1485a463..243aa54c9 100644 --- a/tableauserverclient/server/endpoint/groups_endpoint.py +++ b/tableauserverclient/server/endpoint/groups_endpoint.py @@ -58,10 +58,10 @@ def create(self, group_item): def remove_user(self, group_item, user_id): self._remove_user(group_item, user_id) try: - user_set = group_item.users - for user in user_set: + users = group_item.users + for user in users: if user.id == user_id: - user_set.remove(user) + users.remove(user) break except UnpopulatedPropertyError: # If we aren't populated, do nothing to the user list @@ -73,9 +73,9 @@ def remove_user(self, group_item, user_id): def add_user(self, group_item, user_id): new_user = self._add_user(group_item, user_id) try: - user_set = group_item.users - user_set.add(new_user) - group_item._set_users(user_set) + users = group_item.users + users.append(new_user) + group_item._set_users(users) except UnpopulatedPropertyError: # If we aren't populated, do nothing to the user list pass diff --git a/test/test_group.py b/test/test_group.py index 2f7f22701..20c45455d 100644 --- a/test/test_group.py +++ b/test/test_group.py @@ -92,7 +92,7 @@ def test_add_user(self): m.post(self.baseurl + '/e7833b48-c6f7-47b5-a2a7-36e7dd232758/users', text=response_xml) single_group = TSC.GroupItem('test') single_group._id = 'e7833b48-c6f7-47b5-a2a7-36e7dd232758' - single_group._users = set() + single_group._users = [] self.server.groups.add_user(single_group, '5de011f8-5aa9-4d5b-b991-f462c8dd6bb7') self.assertEqual(1, len(single_group.users))