8000 Jorwoods/tasks no schedule by jorwoods · Pull Request #1297 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Jorwoods/tasks no schedule #1297

New issue < 8000 button aria-label="Close dialog" data-close-dialog="" type="button" data-view-component="true" class="Link--muted btn-link position-absolute p-4 right-0">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jan 4, 2024
Merged

Jorwoods/tasks no schedule #1297

merged 12 commits into from
Jan 4, 2024

Conversation

jorwoods
Copy link
Contributor

My thoughts on resolving #1290 and adding type annotations on tasks. I noticed at the moment, running a task returns the raw bytes from the server response. A change to the TSC API would be consuming that response and returning a JobItem.

@jorwoods
Copy link
Contributor Author

Seems that the token for the test coverage has some missing permissions.
https://github.com/tableau/server-client-python/settings/actions

@bcantoni
Copy link
Contributor

@jacalata could you take a look at the issue here with generating test coverage: https://github.com/tableau/server-client-python/actions/runs/6527723147/job/17869783004?pr=1297

@jorwoods jorwoods force-pushed the jorwoods/tasks_no_schedule branch from 02ac7fb to 11656c4 Compare November 21, 2023 16:42
@jacalata jacalata merged commit 696f20d into tableau:development Jan 4, 2024
jacalata added a commit that referenced this pull request Jan 13, 2024
@jacalata
promote code for 0.29
0e46e15 
#1302 
#1300 
#1330 
#1328 
#1297 
#1307 
#1299 
- fix filename handling in downloads
- fix typing on revisions files
- add typings
- update urllib dependency
@jorwoods jorwoods deleted the jorwoods/tasks_no_schedule branch June 7, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacalata jacalata jacalata approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorwoods @bcantoni @jacalata
0