8000 License text not included in source distribution · Issue #224 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

License text not included in source distribution #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
akaihola opened this issue Sep 19, 2017 · 0 comments
Closed

License text not included in source distribution #224

akaihola opened this issue Sep 19, 2017 · 0 comments

Comments

@akaihola
Copy link

The LICENSE file in this tableau/server-client-python repository contains the MIT license text. When building a source .tar.gz distribution, the file is omitted:

$ git clone -q https://github.com/tableau/server-client-python.git
$ cd server-client-python
$ python setup.py sdist
running sdist
[...]
Creating tar archive
removing 'tableauserverclient-0.4.1' (and everything under it)

$ tar tvf dist/*.tar.gz | egrep 'LICENSE|setup\.py|MANIFEST\.in'
-rw-rw-r-- myself/myself   754 2017-09-19 13:25 tableauserverclient-0.4.1/setup.py
-rw-rw-r-- myself/myself    62 2017-09-19 13:25 tableauserverclient-0.4.1/MANIFEST.in

As a result, also the tarball downloadable from PyPI doesn't contain any license text:

curl https://pypi.python.org/packages/95/f6/36b4a43a41af2cb01b74a0a047fd4d7108af72ff1a351adca12b37647732/tableauserverclient-0.4.1.tar.gz \
| tar tz \
| egrep 'LICENSE|setup\.py|MANIFEST\.in'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 55277  100 55277    0     0   149k      0 --:--:-- --:--:-- --:--:--  149k
tableauserverclient-0.4.1/MANIFEST.in
tableauserverclient-0.4.1/setup.py

The only mention of the license in the source distribution is license='MIT' in setup.py, which is not sufficient. I believe this omission prevents e.g. our company from installing the library on our customers' servers.

For an example of how to ensure inclusion of the license file, please see the Python Packaging User Guide and the sample project it provides containing the MANIFEST.in and setup.py files.

Also, it seems that versioneer.py isn't distributed under the MIT license, but CC0-1.0. Is it actually necessary to include versioneer.py in MANIFEST.in and thus in the source distribution, since it has already done its job at that point? The _tableauserverclient/_version.py it generates gets included (and that file by the way is also under CC0-1.0). That license is not mentioned in setup.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akaihola
0