8000 Comparing master...jac/users-csv · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tableau/server-client-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tableau/server-client-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: jac/users-csv
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 19 files changed
  • 2 contributors

Commits on Oct 30, 2024

  1. implement csv import with validation

    created enums to hold the expected values for each field
    included some simple rules like no repeating @,
    included tests
    
    (cherry picked from commit 5eb8f1e)
    
    implement csv import with validation
    
    created enums to hold the expected values for each field
    included some simple rules like no repeating @,
    included tests
    
    (cherry picked from commit 5eb8f1e)
    jacalata committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ba5eff5 View commit details
    Browse the repository at this point in the history
  2. add two auth types

    jacalata committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    5daf9b9 View commit details
    Browse the repository at this point in the history
  3. Add CSV Import logic

    Also add tests for the importing
    jacalata committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    aa9d1d7 View commit details
    Browse the repository at this point in the history
  4. separate valid and invalid user tests

    (cherry picked from commit 098c6d3)
    jacalata committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    9e9d44b View commit details
    Browse the repository at this point in the history
  5. maybe improvements

    jacalata committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    42aadf8 View commit details
    Browse the repository at this point in the history
Loading
0