8000 fix comment in sample · tableau/server-client-python@af6f290 · GitHub
[go: up one dir, main page]

Skip to content

Commit af6f290

Browse files
committed
fix comment in sample
1 parent 7c58b5a commit af6f290

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

samples/filter_sort_groups.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,13 +99,18 @@ def main():
9999

100100
print("----")
101101
# or, try the above with the django style filtering.
102-
"""
103-
bug: hangs getting the version for this request? Also should be order_by, not sort
104-
groups = ["SALES NORTHWEST", "SALES ROMANIA", "this_group"]
105-
groups = [urllib.parse.quote_plus(group) for group in groups]
106-
for group in server.groups.filter(name__in=groups).order_by("-name"):
107-
print(group.name)
108-
"""
102+
all_g = server.groups.all()
103+
print(f"Searching locally among {all_g.total_available} groups")
104+
for a in all_g:
105+
print(a)
106+
groups = [urllib.parse.quote_plus(group) for group in ["SALES NORTHWEST", "SALES ROMANIA", "this_group"]]
107+
print(groups)
108+
109+
# BUG: this loop seems to continue making requests long after we've seen all groups
110+
#for group in server.groups.filter(name__in=groups).order_by("-name"):
111+
# print(group.name)
112+
113+
print("done")
109114

110115

111116
if __name__ == "__main__":

0 commit comments

Comments
 (0)
0