8000 Merge pull request #462 from tableau/release-0.8.1 · tableau/server-client-python@89ef6f7 · GitHub
[go: up one dir, main page]
Skip to content

Commit 89ef6f7

Browse files
author
Chris Shin
authored
Merge pull request #462 from tableau/release-0.8.1
Release 0.8.1 * Fixed update_workbook endpoint (#454)
2 parents f6d4d35 + b9ea51e commit 89ef6f7

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

‎.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
language: python
22
python:
33
- "2.7"
4-
- "3.3"
5-
- "3.4"
64
- "3.5"
75
- "3.6"
86
- "pypy"

‎CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.8.1 (17 July 2019)
2+
3+
* Fixed update_workbook endpoint (#454)
4+
15
## 0.8 (8 Apr 2019)
26

37
* Added Max Age to download view image request (#360)

‎tableauserverclient/server/request_factory.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,15 +374,16 @@ def update_req(self, workbook_item):
374374
workbook_element = ET.SubElement(xml_request, 'workbook')
375375
if workbook_item.name:
376376
workbook_element.attrib['name'] = workbook_item.name
377-
if workbook_item.show_tabs:
377+
if workbook_item.show_tabs is not None:
378378
workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower()
379379
if workbook_item.project_id:
380380
project_element = ET.SubElement(workbook_element, 'project')
381381
project_element.attrib['id'] = workbook_item.project_id
382382
if workbook_item.owner_id:
383383
owner_element = ET.SubElement(workbook_element, 'owner')
384384
owner_element.attrib['id'] = workbook_item.owner_id
385-
if workbook_item.materialized_views_config is not None:
385+
if workbook_item.materialized_views_config['materialized_views_enabled']\
386+
and workbook_item.materialized_views_config['run_materialization_now']:
386387
materialized_views_config = workbook_item.materialized_views_config
387388
materialized_views_element = ET.SubElement(workbook_element, 'materializedViewsEnablementConfig')
388389
materialized_views_element.attrib['materializedViewsEnabled'] = str(materialized_views_config

‎test/test_sort.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_filter_in(self):
5858
auth_token='j80k54ll2lfMZ0tv97mlPvvSCRyD0DOM',
5959
content_type='text/xml')
6060

61-
self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:[stocks,market]')
61+
self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:%5bstocks,market%5d')
6262

6363
def test_sort_asc(self):
6464
with requests_mock.mock() as m:

0 commit comments

Comments
 (0)
0