Fix for 162 (#163)

t8y8 · web-flow · commit 3fb1c4a61bf0 · 2017-04-10T11:08:12.000-07:00
diff --git a/tableauserverclient/server/endpoint/groups_endpoint.py b/tableauserverclient/server/endpoint/groups_endpoint.py
@@ -58,10 +58,10 @@ def create(self, group_item):
     def remove_user(self, group_item, user_id):
         self._remove_user(group_item, user_id)
         try:
-            user_set = group_item.users
-            for user in user_set:
+            users = group_item.users
+            for user in users:
                 if user.id == user_id:
-                    user_set.remove(user)
+                    users.remove(user)
                     break
         except UnpopulatedPropertyError:
             # If we aren't populated, do nothing to the user list
@@ -73,9 +73,9 @@ def remove_user(self, group_item, user_id):
     def add_user(self, group_item, user_id):
         new_user = self._add_user(group_item, user_id)
         try:
-            user_set = group_item.users
-            user_set.add(new_user)
-            group_item._set_users(user_set)
+            users = group_item.users
+            users.append(new_user)
+            group_item._set_users(users)
         except UnpopulatedPropertyError:
             # If we aren't populated, do nothing to the user list
             pass
diff --git a/test/test_group.py b/test/test_group.py
@@ -92,7 +92,7 @@ def test_add_user(self):
             m.post(self.baseurl + '/e7833b48-c6f7-47b5-a2a7-36e7dd232758/users', text=response_xml)
             single_group = TSC.GroupItem('test')
             single_group._id = 'e7833b48-c6f7-47b5-a2a7-36e7dd232758'
-            single_group._users = set()
+            single_group._users = []
             self.server.groups.add_user(single_group, '5de011f8-5aa9-4d5b-b991-f462c8dd6bb7')
 
         self.assertEqual(1, len(single_group.users))
