8000 Fix typing issues · tableau/server-client-python@2b40824 · GitHub
[go: up one dir, main page]
Skip to content
Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 2b40824

Browse files
Jordan WoodsJordan Woods
Jordan Woods
authored and
Jordan Woods
committed
Fix typing issues
1 parent 55fd352 commit 2b40824

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

‎tableauserverclient/server/endpoint/groups_endpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def user_pager():
4747

4848
def _get_users_for_group(
4949
self, group_item, req_options: Optional["RequestOptions"] = None
50-
) -> Tuple[List[GroupItem], PaginationItem]:
50+
) -> Tuple[List[UserItem], PaginationItem]:
8000 5151
url = "{0}/{1}/users".format(self.baseurl, group_item.id)
5252
server_response = self.get_request(url, req_options)
5353
user_item = UserItem.from_response(server_response.content, self.parent_srv.namespace)

‎test/test_group.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def test_add_user_missing_user_id(self) -> None:
148148

149149
def test_add_user_missing_group_id(self) -> None:
150150
single_group = TSC.GroupItem("test")
151-
single_group._users = []
151+
single_group._users = [] # type: ignore[assignment]
152152
self.assertRaises(
153153
TSC.MissingRequiredFieldError,
154154
self.server.groups.add_user,
@@ -183,7 +183,7 @@ def test_remove_user_missing_user_id(self) -> None:
183183

184184
def test_remove_user_missing_group_id(self) -> None:
185185
single_group = TSC.GroupItem("test")
186-
single_group._users = []
186+
single_group._users = [] # type: ignore[assignment]
187187
self.assertRaises(
188188
TSC.MissingRequiredFieldError,
189189
self.server.groups.remove_user,

‎test/test_project.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ def test_update_datasource_default_permission(self) -> None:
119119

120120
capabilities = {TSC.Permission.Capability.ExportXml: TSC.Permission.Mode.Deny}
121121

122-
rules = [TSC.PermissionsRule(grantee=group, capabilities=capabilities)]
122+
rules = [TSC.PermissionsRule(grantee=group.to_reference(), capabilities=capabilities)] # type: ignore[arg-type]
123123

124124
new_rules = self.server.projects.update_datasource_default_permissions(project, rules)
125125

@@ -236,7 +236,7 @@ def test_delete_permission(self) -> None:
236236
if permission.grantee.id == single_group._id:
237237
capabilities = permission.capabilities
238238

239-
rules = TSC.PermissionsRule(grantee=single_group, capabilities=capabilities)
239+
rules = TSC.PermissionsRule(grantee=single_group.to_reference(), capabilities=capabilities)
240240

241241
endpoint = "{}/permissions/groups/{}".format(single_project._id, single_group._id)
242242
m.delete("{}/{}/Read/Allow".format(self.baseurl, endpoint), status_code=204)
@@ -282,7 +282,7 @@ def test_delete_workbook_default_permission(self) -> None:
282282
TSC.Permission.Capability.ChangePermissions: TSC.Permission.Mode.Allow,
283283
}
284284

285-
rules = TSC.PermissionsRule(grantee=single_group, capabilities=capabilities)
285+
rules = TSC.PermissionsRule(grantee=single_group.to_reference(), capabilities=capabilities) # type: ignore[arg-type]
286286

287287
endpoint = "{}/default-permissions/workbooks/groups/{}".format(single_project._id, single_group._id)
288288
m.delete("{}/{}/Read/Allow".format(self.baseurl, endpoint), status_code=204)

0 commit comments

Comments
 (0)
0