8000 chore: remove deprecated arg from download datasource · tableau/server-client-python@281ae3e · GitHub
[go: up one dir, main page]

Skip to content

Commit 281ae3e

Browse files
committed
chore: remove deprecated arg from download datasource
1 parent dd04bbd commit 281ae3e

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

tableauserverclient/server/endpoint/datasources_endpoint.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,13 @@ def download(
126126
datasource_id: str,
127127
filepath: Optional[PathOrFileW] = None,
128128
include_extract: bool = True,
129-
no_extract: Optional[bool] = None,
130129
) -> str:
131-
return self.download_revision(datasource_id, None, filepath, include_extract, no_extract)
130+
return self.download_revision(
131+
datasource_id,
132+
None,
133+
filepath,
134+
include_extract,
135+
)
132136

133137
# Update datasource
134138
@api(version="2.0")
@@ -404,7 +408,6 @@ def download_revision(
404408
revision_number: str,
405409
filepath: Optional[PathOrFileW] = None,
406410
include_extract: bool = True,
407-
no_extract: Optional[bool] = None,
408411
) -> PathOrFileW:
409412
if not datasource_id:
410413
error = "Datasource ID undefined."
@@ -413,14 +416,6 @@ def download_revision(
413416
url = "{0}/{1}/content".format(self.baseurl, datasource_id)
414417
else:
415418
url = "{0}/{1}/revisions/{2}/content".format(self.baseurl, datasource_id, revision_number)
416-
if no_extract is False or no_extract is True:
417-
import warnings
418-
419-
warnings.warn(
420-
"no_extract is deprecated, use include_extract instead.",
421-
DeprecationWarning,
422-
)
423-
include_extract = not no_extract
424419

425420
if not include_extract:
426421
url += "?includeExtract=False"

0 commit comments

Comments
 (0)
0