Fix typing issues

Jordan Woods · Jordan Woods · commit 1b785959f307 · 2022-01-28T14:00:29.000-06:00
diff --git a/tableauserverclient/server/endpoint/groups_endpoint.py b/tableauserverclient/server/endpoint/groups_endpoint.py
@@ -47,7 +47,7 @@ def user_pager():
 
     def _get_users_for_group(
         self, group_item, req_options: Optional["RequestOptions"] = None
-    ) -> Tuple[List[GroupItem], PaginationItem]:
+    ) -> Tuple[List[UserItem], PaginationItem]:
         url = "{0}/{1}/users".format(self.baseurl, group_item.id)
         server_response = self.get_request(url, req_options)
         user_item = UserItem.from_response(server_response.content, self.parent_srv.namespace)
diff --git a/test/test_group.py b/test/test_group.py
@@ -148,7 +148,7 @@ def test_add_user_missing_user_id(self) -> None:
 
     def test_add_user_missing_group_id(self) -> None:
         single_group = TSC.GroupItem("test")
-        single_group._users = []
+        single_group._users = []  # type:ignore[assignment]
         self.assertRaises(
             TSC.MissingRequiredFieldError,
             self.server.groups.add_user,
@@ -183,7 +183,7 @@ def test_remove_user_missing_user_id(self) -> None:
 
     def test_remove_user_missing_group_id(self) -> None:
         single_group = TSC.GroupItem("test")
-        single_group._users = []
+        single_group._users = []  # type:ignore[assignment]
         self.assertRaises(
             TSC.MissingRequiredFieldError,
             self.server.groups.remove_user,
diff --git a/test/test_project.py b/test/test_project.py
@@ -119,7 +119,9 @@ def test_update_datasource_default_permission(self) -> None:
 
             capabilities = {TSC.Permission.Capability.ExportXml: TSC.Permission.Mode.Deny}
 
-            rules = [TSC.PermissionsRule(grantee=group, capabilities=capabilities)]
+            rules = [
+                TSC.PermissionsRule(grantee=group.to_reference(), capabilities=capabilities)  # type:ignore[arg-type]
+            ]
 
             new_rules = self.server.projects.update_datasource_default_permissions(project, rules)
 
@@ -236,7 +238,9 @@ def test_delete_permission(self) -> None:
                     if permission.grantee.id == single_group._id:
                         capabilities = permission.capabilities
 
-            rules = TSC.PermissionsRule(grantee=single_group, capabilities=capabilities)
+            rules = TSC.PermissionsRule(
+                grantee=single_group.to_reference(), capabilities=capabilities
+            )  # type:ignore[arg-type]
 
             endpoint = "{}/permissions/groups/{}".format(single_project._id, single_group._id)
             m.delete("{}/{}/Read/Allow".format(self.baseurl, endpoint), status_code=204)
@@ -282,7 +286,9 @@ def test_delete_workbook_default_permission(self) -> None:
                 TSC.Permission.Capability.ChangePermissions: TSC.Permission.Mode.Allow,
             }
 
-            rules = TSC.PermissionsRule(grantee=single_group, capabilities=capabilities)
+            rules = TSC.PermissionsRule(
+                grantee=single_group.to_reference(), capabilities=capabilities  # type:ignore[arg-type]
+            )
 
             endpoint = "{}/default-permissions/workbooks/groups/{}".format(single_project._id, single_group._id)
             m.delete("{}/{}/Read/Allow".format(self.baseurl, endpoint), status_code=204)
