bug symfony#52797 [VarExporter] Fix lazy ghost trait when using nullsafe operator (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit fd5bc712ebf5 · 2023-11-29T18:09:10.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [VarExporter] Fix lazy ghost trait when using nullsafe operator | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix symfony#52793 | License | MIT My bad. Tests coming. The issue happens only when using the nullsafe operator so the short-term workaround is using isset + ternary instead. Commits ------- 7c7adab [VarExporter] Fix lazy ghost trait when using nullsafe operator
diff --git a/src/Symfony/Component/VarExporter/LazyGhostTrait.php b/src/Symfony/Component/VarExporter/LazyGhostTrait.php
@@ -175,8 +175,9 @@ public function &__get($name): mixed
             if ($state && (null === $scope || isset($propertyScopes["\0$scope\0$name"]))) {
                 if (LazyObjectState::STATUS_INITIALIZED_FULL === $state->status) {
                     // Work around php/php-src#12695
-                    $property = $propertyScopes[null === $scope ? $name : "\0$scope\0$name"][3]
-                        ?? (Hydrator::$propertyScopes[$this::class] = Hydrator::getPropertyScopes($this::class))[3];
+                    $property = null === $scope ? $name : "\0$scope\0$name";
+                    $property = $propertyScopes[$property][3]
+                        ?? Hydrator::$propertyScopes[$this::class][$property][3] = new \ReflectionProperty($scope ?? $class, $name);
                 } else {
                     $property = null;
                 }
diff --git a/src/Symfony/Component/VarExporter/Tests/Fixtures/LazyGhost/ChildMagicClass.php b/src/Symfony/Component/VarExporter/Tests/Fixtures/LazyGhost/ChildMagicClass.php
@@ -18,5 +18,14 @@ class ChildMagicClass extends MagicClass implements LazyObjectInterface
 {
     use LazyGhostTrait;
 
+    private const LAZY_OBJECT_PROPERTY_SCOPES = [
+        "\0".self::class."\0".'data' => [self::class, 'data', null],
+        "\0".self::class."\0".'lazyObjectState' => [self::class, 'lazyObjectState', null],
+        "\0".parent::class."\0".'data' => [parent::class, 'data', null],
+        'cloneCounter' => [self::class, 'cloneCounter', null],
+        'data' => [self::class, 'data', null],
+        'lazyObjectState' => [self::class, 'lazyObjectState', null],
+    ];
+
     private int $data = 123;
 }

Original file line number	Diff line number	Diff line change
`@@ -18,5 +18,14 @@ class ChildMagicClass extends MagicClass implements LazyObjectInterface`
`18`	`18`	`{`
`19`	`19`	`use LazyGhostTrait;`
`20`	`20`
	`21`	`+ private const LAZY_OBJECT_PROPERTY_SCOPES = [`
	`22`	`+ "\0".self::class."\0".'data' => [self::class, 'data', null],`
	`23`	`+ "\0".self::class."\0".'lazyObjectState' => [self::class, 'lazyObjectState', null],`
	`24`	`+ "\0".parent::class."\0".'data' => [parent::class, 'data', null],`
	`25`	`+ 'cloneCounter' => [self::class, 'cloneCounter', null],`
	`26`	`+ 'data' => [self::class, 'data', null],`
	`27`	`+ 'lazyObjectState' => [self::class, 'lazyObjectState', null],`
	`28`	`+ ];`
	`29`	`+`
`21`	`30`	`private int $data = 123;`
`22`	`31`	`}`