minor symfony#52717 [Cache] Get TRUNCATE statement from platform (derrabus)

nicolas-grekas · nicolas-grekas · commit b6404af620ba · 2023-11-24T15:52:46.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Get TRUNCATE statement from platform | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT The DBAL platform knows how to build a `TRUNCATE` query and which databases support it. Let's leverage that functionality. Commits ------- 7cac14d [Cache] Get TRUNCATE statement from platform
diff --git a/src/Symfony/Component/Cache/Adapter/DoctrineDbalAdapter.php b/src/Symfony/Component/Cache/Adapter/DoctrineDbalAdapter.php
@@ -213,11 +213,7 @@ protected function doHave(string $id): bool
     protected function doClear(string $namespace): bool
     {
         if ('' === $namespace) {
-            if ('sqlite' === $this->getPlatformName()) {
-                $sql = "DELETE FROM $this->table";
-            } else {
-                $sql = "TRUNCATE TABLE $this->table";
-            }
+            $sql = $this->conn->getDatabasePlatform()->getTruncateTableSQL($this->table);
         } else {
             $sql = "DELETE FROM $this->table WHERE $this->idCol LIKE '$namespace%'";
         }

Original file line number	Diff line number	Diff line change
`@@ -213,11 +213,7 @@ protected function doHave(string $id): bool`
`213`	`213`	`protected function doClear(string $namespace): bool`
`214`	`214`	`{`
`215`	`215`	`if ('' === $namespace) {`
`216`		`- if ('sqlite' === $this->getPlatformName()) {`
`217`		`- $sql = "DELETE FROM $this->table";`
`218`		`- } else {`
`219`		`- $sql = "TRUNCATE TABLE $this->table";`
`220`		`- }`
	`216`	`+ $sql = $this->conn->getDatabasePlatform()->getTruncateTableSQL($this->table);`
`221`	`217`	`} else {`
`222`	`218`	`$sql = "DELETE FROM $this->table WHERE $this->idCol LIKE '$namespace%'";`
`223`	`219`	`}`