minor symfony#54534 [TwigBundle] Don't register emoji extension on missing intl extension (alexandre-daubois)

nicolas-grekas · nicolas-grekas · commit a8b4739a2a9c · 2024-04-09T13:27:41.000+02:00
This PR was merged into the 7.1 branch. Discussion ---------- [TwigBundle] Don't register emoji extension on missing `intl` extension | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Appveyor is failing a log because Twig bundle tries to load Emoji transliterator even if ext-intl is not present. Snippet of the error: ``` 8) Symfony\Bundle\SecurityBundle\Tests\Functional\CsrfFormLoginTest::testFormLoginRedirectsToProtectedResourceAfterLogin with data set #0 (array('CsrfFormLogin', 'config.yml')) LogicException: You cannot use the "Symfony\Component\Emoji\EmojiTransliterator" class as the "intl" extension is not installed. See https://php.net/intl. C:\projects\symfony\src\Symfony\Component\Emoji\EmojiTransliterator.php:17 C:\projects\symfony\src\Symfony\Component\ErrorHandler\DebugClassLoader.php:304 C:\projects\symfony\src\Symfony\Bundle\TwigBundle\DependencyInjection\Compiler\ExtensionPass.php:35 C:\projects\symfony\src\Symfony\Component\DependencyInjection\Compiler\Compiler.php:73 C:\projects\symfony\src\Symfony\Component\DependencyInjection\ContainerBuilder.php:750 C:\projects\symfony\src\Symfony\Component\HttpKernel\Kernel.php:495 C:\projects\symfony\src\Symfony\Component\HttpKernel\Kernel.php:732 C:\projects\symfony\src\Symfony\Component\HttpKernel\Kernel.php:120 C:\projects\symfony\src\Symfony\Bundle\FrameworkBundle\Test\KernelTestCase.php:67 C:\projects\symfony\src\Symfony\Bundle\FrameworkBundle\Test\WebTestCase.php:44 C:\projects\symfony\src\Symfony\Bundle\SecurityBundle\Tests\Functional\CsrfFormLoginTest.php:111 ``` Commits ------- 1a90ba8 [TwigBundle] Don't register emoji extension on missing `intl` extension
diff --git a/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php b/src/Symfony/Bundle/TwigBundle/DependencyInjection/Compiler/ExtensionPass.php
@@ -32,7 +32,7 @@ public function process(ContainerBuilder $container): void
             $container->removeDefinition('twig.extension.assets');
         }
 
-        if (!class_exists(EmojiTransliterator::class)) {
+        if (!class_exists(\Transliterator::class) || !class_exists(EmojiTransliterator::class)) {
             $container->removeDefinition('twig.extension.emoji');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ public function process(ContainerBuilder $container): void`
`32`	`32`	`$container->removeDefinition('twig.extension.assets');`
`33`	`33`	`}`
`34`	`34`
`35`		`- if (!class_exists(EmojiTransliterator::class)) {`
	`35`	`+ if (!class_exists(\Transliterator::class) \|\| !class_exists(EmojiTransliterator::class)) {`
`36`	`36`	`$container->removeDefinition('twig.extension.emoji');`
`37`	`37`	`}`
`38`	`38`