minor symfony#58578 [Cache] recreate the schema for every single test (xabbuh)

fabpot · fabpot · commit 5b30bc6f6684 · 2024-10-18T08:57:02.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Cache] recreate the schema for every single test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The former test implementation relied on the order in which tests are executed assuming that tests explicitly creating the schema were executed first. This assumption leads to test failures on PHPUnit 10+ were tests defined in parent classes are run first where they were run later with PHPUnit 9.6. Commits ------- 633a60e drop existing schema if tests create it explicitly
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/DoctrineDbalAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/DoctrineDbalAdapterTest.php
@@ -48,6 +48,10 @@ public function createCachePool(int $defaultLifetime = 0): CacheItemPoolInterfac
 
     public function testConfigureSchemaDecoratedDbalDriver()
     {
+        if (file_exists(self::$dbFile)) {
+            @unlink(self::$dbFile);
+        }
+
         $connection = DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile], $this->getDbalConfig());
         if (!interface_exists(Middleware::class)) {
             $this->markTestSkipped('doctrine/dbal v2 does not support custom drivers using middleware');
@@ -73,6 +77,10 @@ public function testConfigureSchemaDecoratedDbalDriver()
 
     public function testConfigureSchema()
     {
+        if (file_exists(self::$dbFile)) {
+            @unlink(self::$dbFile);
+        }
+
         $connection = DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile], $this->getDbalConfig());
         $schema = new Schema();
 
@@ -83,6 +91,10 @@ public function testConfigureSchema()
 
     public function testConfigureSchemaDifferentDbalConnection()
     {
+        if (file_exists(self::$dbFile)) {
+            @unlink(self::$dbFile);
+        }
+
         $otherConnection = $this->createConnectionMock();
         $schema = new Schema();
 
@@ -93,6 +105,10 @@ public function testConfigureSchemaDifferentDbalConnection()
 
     public function testConfigureSchemaTableExists()
     {
+        if (file_exists(self::$dbFile)) {
+            @unlink(self::$dbFile);
+        }
+
         $connection = DriverManager::getConnection(['driver' => 'pdo_sqlite', 'path' => self::$dbFile], $this->getDbalConfig());
         $schema = new Schema();
         $schema->createTable('cache_items');
