[Routing] Fix removing aliases pointing to removed route in RouteCollection::remove()

fancyweb · fancyweb · commit 238894bdc0d8 · 2023-11-29T17:36:07.000+01:00
diff --git a/src/Symfony/Component/Routing/RouteCollection.php b/src/Symfony/Component/Routing/RouteCollection.php
@@ -157,8 +157,15 @@ public function get(string $name)
      */
     public function remove($name)
     {
-        foreach ((array) $name as $n) {
-            unset($this->routes[$n], $this->priorities[$n], $this->aliases[$n]);
+        $names = (array) $name;
+        foreach ($names as $n) {
+            unset($this->routes[$n], $this->priorities[$n]);
+        }
+
+        foreach ($this->aliases as $k => $alias) {
+            if (\in_array($alias->getId(), $names, true)) {
+                unset($this->aliases[$k]);
+            }
         }
     }
 
diff --git a/src/Symfony/Component/Routing/Tests/RouteCollectionTest.php b/src/Symfony/Component/Routing/Tests/RouteCollectionTest.php
@@ -225,11 +225,13 @@ public function testRemove()
         $collection1->add('bar', $bar = new Route('/bar'));
         $collection->addCollection($collection1);
         $collection->add('last', $last = new Route('/last'));
+        $collection->addAlias('ccc_my_custom_alias', 'foo');
 
         $collection->remove('foo');
         $this->assertSame(['bar' => $bar, 'last' => $last], $collection->all(), '->remove() can remove a single route');
         $collection->remove(['bar', 'last']);
         $this->assertSame([], $collection->all(), '->remove() accepts an array and can remove multiple routes at once');
+        $this->assertNull($collection->getAlias('ccc_my_custom_alias'));
     }
 
     public function testSetHost()

Original file line number	Diff line number	Diff line change
`@@ -157,8 +157,15 @@ public function get(string $name)`
`157`	`157`	`*/`
`158`	`158`	`public function remove($name)`
`159`	`159`	`{`
`160`		`- foreach ((array) $name as $n) {`
`161`		`- unset($this->routes[$n], $this->priorities[$n], $this->aliases[$n]);`
	`160`	`+ $names = (array) $name;`
	`161`	`+ foreach ($names as $n) {`
	`162`	`+ unset($this->routes[$n], $this->priorities[$n]);`
	`163`	`+ }`
	`164`	`+`
	`165`	`+ foreach ($this->aliases as $k => $alias) {`
	`166`	`+ if (\in_array($alias->getId(), $names, true)) {`
	`167`	`+ unset($this->aliases[$k]);`
	`168`	`+ }`
`162`	`169`	`}`
`163`	`170`	`}`
`164`	`171`