Replace ctype_digit check with just a lower than comparison

symfonyaml · symfonyaml · commit 1b26cf23fb26 · 2025-01-12T18:59:00.000+01:00
diff --git a/src/Symfony/Component/Validator/Constraints/VideoValidator.php b/src/Symfony/Component/Validator/Constraints/VideoValidator.php
@@ -69,7 +69,7 @@ public function validate(mixed $value, Constraint $constraint): void
         $height = $dimensions->getHeight();
 
         if ($constraint->minWidth) {
-            if (!ctype_digit((string) $constraint->minWidth)) {
+            if ($constraint->minWidth < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum width.', $constraint->minWidth));
             }
 
@@ -85,7 +85,7 @@ public function validate(mixed $value, Constraint $constraint): void
         }
 
         if ($constraint->maxWidth) {
-            if (!ctype_digit((string) $constraint->maxWidth)) {
+            if ($constraint->maxWidth < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum width.', $constraint->maxWidth));
             }
 
@@ -101,7 +101,7 @@ public function validate(mixed $value, Constraint $constraint): void
         }
 
         if ($constraint->minHeight) {
-            if (!ctype_digit((string) $constraint->minHeight)) {
+            if ($constraint->minHeight < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum height.', $constraint->minHeight));
             }
 
@@ -117,7 +117,7 @@ public function validate(mixed $value, Constraint $constraint): void
         }
 
         if ($constraint->maxHeight) {
-            if (!ctype_digit((string) $constraint->maxHeight)) {
+            if ($constraint->maxHeight < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum height.', $constraint->maxHeight));
             }
 
@@ -133,7 +133,7 @@ public function validate(mixed $value, Constraint $constraint): void
         $pixels = $width * $height;
 
         if (null !== $constraint->minPixels) {
-            if (!ctype_digit((string) $constraint->minPixels)) {
+            if ($constraint->minPixels < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum amount of pixels.', $constraint->minPixels));
             }
 
@@ -149,7 +149,7 @@ public function validate(mixed $value, Constraint $constraint): void
         }
 
         if (null !== $constraint->maxPixels) {
-            if (!ctype_digit((string) $constraint->maxPixels)) {
+            if ($constraint->maxPixels < 0) {
                 throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum amount of pixels.', $constraint->maxPixels));
             }
 

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`69`	`69`	`$height = $dimensions->getHeight();`
`70`	`70`
`71`	`71`	`if ($constraint->minWidth) {`
`72`		`- if (!ctype_digit((string) $constraint->minWidth)) {`
	`72`	`+ if ($constraint->minWidth < 0) {`
`73`	`73`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum width.', $constraint->minWidth));`
`74`	`74`	`}`
`75`	`75`
`@@ -85,7 +85,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`if ($constraint->maxWidth) {`
`88`		`- if (!ctype_digit((string) $constraint->maxWidth)) {`
	`88`	`+ if ($constraint->maxWidth < 0) {`
`89`	`89`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum width.', $constraint->maxWidth));`
`90`	`90`	`}`
`91`	`91`
`@@ -101,7 +101,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`if ($constraint->minHeight) {`
`104`		`- if (!ctype_digit((string) $constraint->minHeight)) {`
	`104`	`+ if ($constraint->minHeight < 0) {`
`105`	`105`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum height.', $constraint->minHeight));`
`106`	`106`	`}`
`107`	`107`
`@@ -117,7 +117,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`if ($constraint->maxHeight) {`
`120`		`- if (!ctype_digit((string) $constraint->maxHeight)) {`
	`120`	`+ if ($constraint->maxHeight < 0) {`
`121`	`121`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum height.', $constraint->maxHeight));`
`122`	`122`	`}`
`123`	`123`
`@@ -133,7 +133,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`133`	`133`	`$pixels = $width * $height;`
`134`	`134`
`135`	`135`	`if (null !== $constraint->minPixels) {`
`136`		`- if (!ctype_digit((string) $constraint->minPixels)) {`
	`136`	`+ if ($constraint->minPixels < 0) {`
`137`	`137`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid minimum amount of pixels.', $constraint->minPixels));`
`138`	`138`	`}`
`139`	`139`
`@@ -149,7 +149,7 @@ public function validate(mixed $value, Constraint $constraint): void`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`if (null !== $constraint->maxPixels) {`
`152`		`- if (!ctype_digit((string) $constraint->maxPixels)) {`
	`152`	`+ if ($constraint->maxPixels < 0) {`
`153`	`153`	`throw new ConstraintDefinitionException(\sprintf('"%s" is not a valid maximum amount of pixels.', $constraint->maxPixels));`
`154`	`154`	`}`
`155`	`155`