bug symfony#59033 [WebProfilerBundle] Fix interception for non conventional redirects (Huluti)

nicolas-grekas · nicolas-grekas · commit 068105e4036f · 2025-02-10T15:48:43.000+01:00
This PR was submitted for the 7.2 branch but it was merged into the 6.4 branch instead. Discussion ---------- [WebProfilerBundle] Fix interception for non conventional redirects | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 416aa0e [WebProfilerBundle] Fix interception for non conventional redirects
diff --git a/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php b/src/Symfony/Bundle/WebProfilerBundle/EventListener/WebDebugToolbarListener.php
@@ -107,7 +107,7 @@ public function onKernelResponse(ResponseEvent $event): void
             return;
         }
 
-        if ($response->headers->has('X-Debug-Token') && $response->isRedirect() && $this->interceptRedirects && 'html' === $request->getRequestFormat()) {
+        if ($response->headers->has('X-Debug-Token') && $response->isRedirect() && $this->interceptRedirects && 'html' === $request->getRequestFormat() && $response->headers->has('Location')) {
             if ($request->hasSession() && ($session = $request->getSession())->isStarted() && $session->getFlashBag() instanceof AutoExpireFlashBag) {
                 // keep current flashes for one more request if using AutoExpireFlashBag
                 $session->getFlashBag()->setAll($session->getFlashBag()->peekAll());

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public function onKernelResponse(ResponseEvent $event): void`
`107`	`107`	`return;`
`108`	`108`	`}`
`109`	`109`
`110`		`- if ($response->headers->has('X-Debug-Token') && $response->isRedirect() && $this->interceptRedirects && 'html' === $request->getRequestFormat()) {`
	`110`	`+ if ($response->headers->has('X-Debug-Token') && $response->isRedirect() && $this->interceptRedirects && 'html' === $request->getRequestFormat() && $response->headers->has('Location')) {`
`111`	`111`	`if ($request->hasSession() && ($session = $request->getSession())->isStarted() && $session->getFlashBag() instanceof AutoExpireFlashBag) {`
`112`	`112`	`// keep current flashes for one more request if using AutoExpireFlashBag`
`113`	`113`	`$session->getFlashBag()->setAll($session->getFlashBag()->peekAll());`