doctrine#1169 DDC-3343 - corrected persister logic - only uses the entity persister to perform deletes on the owning side

Ocramius · Ocramius · commit f5705d6d954c · 2015-02-05T00:52:54.000Z
diff --git a/lib/Doctrine/ORM/Persisters/OneToManyPersister.php b/lib/Doctrine/ORM/Persisters/OneToManyPersister.php
@@ -244,10 +244,11 @@ public function removeElement(PersistentCollection $coll, $element)
             return false;
         }
 
-        $class = $this->em->getClassMetadata($mapping['targetEntity']);
-        $sql   = 'DELETE FROM ' . $this->quoteStrategy->getTableName($class, $this->platform)
-            . ' WHERE ' . implode('= ? AND ', $class->getIdentifierColumnNames()) . ' = ?';
+        $this
+            ->uow
+            ->getEntityPersister($mapping['targetEntity'])
+            ->delete($element);
 
-        return (bool) $this->conn->executeUpdate($sql, $this->getDeleteRowSQLParameters($coll, $element));
+        return true;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -244,10 +244,11 @@ public function removeElement(PersistentCollection $coll, $element)`
`244`	`244`	`return false;`
`245`	`245`	`}`
`246`	`246`
`247`		`- $class = $this->em->getClassMetadata($mapping['targetEntity']);`
`248`		`- $sql = 'DELETE FROM ' . $this->quoteStrategy->getTableName($class, $this->platform)`
`249`		`- . ' WHERE ' . implode('= ? AND ', $class->getIdentifierColumnNames()) . ' = ?';`
	`247`	`+ $this`
	`248`	`+ ->uow`
	`249`	`+ ->getEntityPersister($mapping['targetEntity'])`
	`250`	`+ ->delete($element);`
`250`	`251`
`251`		`- return (bool) $this->conn->executeUpdate($sql, $this->getDeleteRowSQLParameters($coll, $element));`
	`252`	`+ return true;`
`252`	`253`	`}`
`253`	`254`	`}`