Fix GitHub output (#10)

Nyholm · web-flow · commit 97fd27b2bc21 · 2021-04-18T16:51:08.000Z
* Fixed Github output

* cs
diff --git a/src/Command/CheckDocsCommand.php b/src/Command/CheckDocsCommand.php
@@ -107,14 +107,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 foreach ($issues as $issue) {
                     $this->io->writeln($issue->__toString());
                 }
+
+                $this->io->error(sprintf('Build completed with %s errors', $issueCount));
             } elseif ('github' === $format) {
                 foreach ($issues as $issue) {
-                    $this->io->writeln(sprintf('::error file=%s,line=%s::[%s] %s', $issue->getFile(), $issue->getLine(), $issue->getType(), $issue->getText()));
+                    $this->io->writeln(sprintf('::error file=%s.rst,line=%s::[%s] %s', $issue->getFile(), $issue->getLine(), $issue->getType(), $issue->getText()));
                 }
             }
 
-            $this->io->error(sprintf('Build completed with %s errors', $issueCount));
-
             return Command::FAILURE;
         }
         $this->io->success('Build completed successfully!');
diff --git a/src/Issue/Issue.php b/src/Issue/Issue.php
@@ -31,7 +31,7 @@ class Issue implements \Stringable
     public function __construct(CodeNode $node, string $text, string $type, string $file, int $localLine)
     {
         $this->node = $node;
-        $this->text = $text;
+        $this->text = trim($text);
         $this->type = $type;
         $this->file = $file;
         $this->localLine = $localLine;

Original file line number	Diff line number	Diff line change
`@@ -107,14 +107,14 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`107`	`107`	`foreach ($issues as $issue) {`
`108`	`108`	`$this->io->writeln($issue->__toString());`
`109`	`109`	`}`
	`110`	`+`
	`111`	`+ $this->io->error(sprintf('Build completed with %s errors', $issueCount));`
`110`	`112`	`} elseif ('github' === $format) {`
`111`	`113`	`foreach ($issues as $issue) {`
`112`		`- $this->io->writeln(sprintf('::error file=%s,line=%s::[%s] %s', $issue->getFile(), $issue->getLine(), $issue->getType(), $issue->getText()));`
	`114`	`+ $this->io->writeln(sprintf('::error file=%s.rst,line=%s::[%s] %s', $issue->getFile(), $issue->getLine(), $issue->getType(), $issue->getText()));`
`113`	`115`	`}`
`114`	`116`	`}`
`115`	`117`
`116`		`- $this->io->error(sprintf('Build completed with %s errors', $issueCount));`
`117`		`-`
`118`	`118`	`return Command::FAILURE;`
`119`	`119`	`}`
`120`	`120`	`$this->io->success('Build completed successfully!');`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class Issue implements \Stringable`
`31`	`31`	`public function __construct(CodeNode $node, string $text, string $type, string $file, int $localLine)`
`32`	`32`	`{`
`33`	`33`	`$this->node = $node;`
`34`		`- $this->text = $text;`
	`34`	`+ $this->text = trim($text);`
`35`	`35`	`$this->type = $type;`
`36`	`36`	`$this->file = $file;`
`37`	`37`	`$this->localLine = $localLine;`