Small bugfix with array index (#24)

Nyholm · web-flow · commit 8bc3354006fe · 2021-04-21T10:42:56.000+02:00
diff --git a/src/Issue/Issue.php b/src/Issue/Issue.php
@@ -78,7 +78,8 @@ public function getErroredLine()
     {
         if (null === $this->erroredLine) {
             $lines = explode(PHP_EOL, $this->node->getValue());
-            $this->erroredLine = $lines[$this->localLine - 1];
+            // We do -1 because the $lines array is zero-index and the error message is 1-index
+            $this->erroredLine = $lines[max(0, $this->localLine - 1)];
         }
 
         return $this->erroredLine;

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,8 @@ public function getErroredLine()`
`78`	`78`	`{`
`79`	`79`	`if (null === $this->erroredLine) {`
`80`	`80`	`$lines = explode(PHP_EOL, $this->node->getValue());`
`81`		`- $this->erroredLine = $lines[$this->localLine - 1];`
	`81`	`+ // We do -1 because the $lines array is zero-index and the error message is 1-index`
	`82`	`+ $this->erroredLine = $lines[max(0, $this->localLine - 1)];`
`82`	`83`	`}`
`83`	`84`
`84`	`85`	`return $this->erroredLine;`