symfony-cli
diff --git a/‎.golangci.yml
Lines changed: 17 additions & 5 deletions
Original file line number Diff line number Diff line change
@@ -59,8 +59,12 @@ func testStdoutCapture(c *C, dst io.Writer) func() {
59 59
60 60 return func() {
61 61 // Close the writer end of the pipe
62 - w.Sync()
63 - w.Close()
62 + if err := w.Sync(); err != nil {
63 + c.Fatalf("err: %s", err)
64 + }
65 + if err := w.Close(); err != nil {
66 + c.Fatalf("err: %s", err)
67 + }
64 68
65 69 // Reset stdout
66 70 os.Stdout = old
@@ -213,7 +217,11 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
213 217 os.Chdir(filepath.Join(home, "project"))
214 218
215 219 os.Rename("git", ".git")
216 - defer os.Rename(".git", "git")
220 + defer func() {
221 + // handling error is not really worth it here: we could not really recover it anyway and the original directory
222 + // is commited
223 + _ = os.Rename(".git", "git")
224 + }()
217 225 defer cleanupExecutorTempFiles()
218 226
219 227 var output bytes.Buffer
@@ -232,8 +240,12 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
232 240 projectFile := filepath.Join(".platform", "local", "project.yaml")
233 241 contents, err := os.ReadFile(projectFile)
234 242 c.Assert(err, IsNil)
235 - defer os.WriteFile(projectFile, contents, 0644)
236 - os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644)
243 + defer func() {
244 + // handling error is not really worth it here: we could not really recover it and anyway the original file
245 + // content is commited
246 + _ = os.WriteFile(projectFile, contents, 0644)
247 + }()
248 + c.Assert(os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644), IsNil)
237 249
238 250 output.Reset()
239 251 outCloser = testStdoutCapture(c, &output) b/‎.golangci.yml
Lines changed: 17 additions & 5 deletions
Original file line number Diff line number Diff line change
@@ -59,8 +59,12 @@ func testStdoutCapture(c *C, dst io.Writer) func() {
59 59
60 60 return func() {
61 61 // Close the writer end of the pipe
62 - w.Sync()
63 - w.Close()
62 + if err := w.Sync(); err != nil {
63 + c.Fatalf("err: %s", err)
64 + }
65 + if err := w.Close(); err != nil {
66 + c.Fatalf("err: %s", err)
67 + }
64 68
65 69 // Reset stdout
66 70 os.Stdout = old
@@ -213,7 +217,11 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
213 217 os.Chdir(filepath.Join(home, "project"))
214 218
215 219 os.Rename("git", ".git")
216 - defer os.Rename(".git", "git")
220 + defer func() {
221 + // handling error is not really worth it here: we could not really recover it anyway and the original directory
222 + // is commited
223 + _ = os.Rename(".git", "git")
224 + }()
217 225 defer cleanupExecutorTempFiles()
218 226
219 227 var output bytes.Buffer
@@ -232,8 +240,12 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
232 240 projectFile := filepath.Join(".platform", "local", "project.yaml")
233 241 contents, err := os.ReadFile(projectFile)
234 242 c.Assert(err, IsNil)
235 - defer os.WriteFile(projectFile, contents, 0644)
236 - os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644)
243 + defer func() {
244 + // handling error is not really worth it here: we could not really recover it and anyway the original file
245 + // content is commited
246 + _ = os.WriteFile(projectFile, contents, 0644)
247 + }()
248 + c.Assert(os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644), IsNil)
237 249
238 250 output.Reset()
239 251 outCloser = testStdoutCapture(c, &output)
diff --git a/‎local/proxy/proxy_test.go
Lines changed: 4 additions & 3 deletions b/‎local/proxy/proxy_test.go
Lines changed: 4 additions & 3 deletions
@@ -59,8 +59,12 @@ func testStdoutCapture(c *C, dst io.Writer) func() {
 
 	return func() {
 		// Close the writer end of the pipe
-		w.Sync()
-		w.Close()
+		if err := w.Sync(); err != nil {
+			c.Fatalf("err: %s", err)
+		}
+		if err := w.Close(); err != nil {
+			c.Fatalf("err: %s", err)
+		}
 
 		// Reset stdout
 		os.Stdout = old
@@ -213,7 +217,11 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
 	os.Chdir(filepath.Join(home, "project"))
 
 	os.Rename("git", ".git")
-	defer os.Rename(".git", "git")
+	defer func() {
+		// handling error is not really worth it here: we could not really recover it anyway and the original directory
+		// is commited
+		_ = os.Rename(".git", "git")
+	}()
 	defer cleanupExecutorTempFiles()
 
 	var output bytes.Buffer
@@ -232,8 +240,12 @@ func (s *ExecutorSuite) TestEnvInjection(c *C) {
 	projectFile := filepath.Join(".platform", "local", "project.yaml")
 	contents, err := os.ReadFile(projectFile)
 	c.Assert(err, IsNil)
-	defer os.WriteFile(projectFile, contents, 0644)
-	os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644)
+	defer func() {
+		// handling error is not really worth it here: we could not really recover it and anyway the original file
+		// content is commited
+		_ = os.WriteFile(projectFile, contents, 0644)
+	}()
+	c.Assert(os.WriteFile(projectFile, bytes.Replace(contents, []byte("bew7pfa7t2ut2"), []byte("aew7pfa7t2ut2"), 1), 0644), IsNil)
 
 	output.Reset()
 	outCloser = testStdoutCapture(c, &output)
 
@@ -59,7 +59,7 @@ func (s *ProxySuite) TestProxy(c *C) {
 		TLD:  "wip",
 		path: "testdata/.symfony5/proxy.json",
 	}, ca, log.New(zerolog.New(os.Stderr), "", 0), true)
-	os.MkdirAll("testdata/.symfony5", 0755)
+	c.Assert(os.MkdirAll("testdata/.symfony5", 0755), IsNil)
 	err = p.Save()
 	c.Assert(err, IsNil)
 
@@ -172,15 +172,16 @@ func (s *ProxySuite) TestProxy(c *C) {
 	{
 		backend := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(200)
-			w.Write([]byte(`http://symfony-no-tls.wip`))
+			_, err := w.Write([]byte(`http://symfony-no-tls.wip`))
+			c.Assert(err, IsNil)
 		}))
 		defer backend.Close()
 		backendURL, err := url.Parse(backend.URL)
 		c.Assert(err, IsNil)
 
 		p := pid.New("symfony_com_no_tls", nil)
 		port, _ := strconv.Atoi(backendURL.Port())
-		p.Write(os.Getpid(), port, "http")
+		c.Assert(p.Write(os.Getpid(), port, "http"), IsNil)
 
 		req, _ := http.NewRequest("GET", "http://symfony-no-tls.wip/", nil)
 		req.Close = true