minor #30965 Prepare for the new serialization mechanism (fancyweb)

fabpot · fabpot · commit 22014b5ba81f · 2019-04-08T08:01:37.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- Prepare for the new serialization mechanism | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - #eufossa Should I maybe split this component by component ? https://wiki.php.net/rfc/custom_object_serialization has been accepted. Best viewed in "split" mode. This work is kind of required for symfony/symfony#30304 so we don't trigger 30 deprecations from our own code base. Commits ------- d412e77a9c Prepare for the new serialization mechanism
diff --git a/Tests/Fixtures/CustomArrayObject.php b/Tests/Fixtures/CustomArrayObject.php
@@ -58,13 +58,23 @@ public function count()
         return \count($this->array);
     }
 
+    public function __serialize(): array
+    {
+        return $this->array;
+    }
+
     public function serialize()
     {
-        return serialize($this->array);
+        return serialize($this->__serialize());
+    }
+
+    public function __unserialize(array $data): void
+    {
+        $this->array = $data;
     }
 
     public function unserialize($serialized)
     {
-        $this->array = (array) unserialize((string) $serialized);
+        $this->__unserialize((array) unserialize((string) $serialized));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -58,13 +58,23 @@ public function count()`
`58`	`58`	`return \count($this->array);`
`59`	`59`	`}`
`60`	`60`
	`61`	`+ public function __serialize(): array`
	`62`	`+ {`
	`63`	`+ return $this->array;`
	`64`	`+ }`
	`65`	`+`
`61`	`66`	`public function serialize()`
`62`	`67`	`{`
`63`		`- return serialize($this->array);`
	`68`	`+ return serialize($this->__serialize());`
	`69`	`+ }`
	`70`	`+`
	`71`	`+ public function __unserialize(array $data): void`
	`72`	`+ {`
	`73`	`+ $this->array = $data;`
`64`	`74`	`}`
`65`	`75`
`66`	`76`	`public function unserialize($serialized)`
`67`	`77`	`{`
`68`		`- $this->array = (array) unserialize((string) $serialized);`
	`78`	`+ $this->__unserialize((array) unserialize((string) $serialized));`
`69`	`79`	`}`
`70`	`80`	`}`