8000 minor #1478 [StimulusBundle/TwigComponent] Fix "use_yield" to "true" … · symfony/ux@33c66f3 · GitHub
[go: up one dir, main page]
Skip to content

Commit 33c66f3

Browse files
weaverryanweaverryan
committed
minor #1478 [StimulusBundle/TwigComponent] Fix "use_yield" to "true" deprecation notice in CI (evertharmeling)
This PR was merged into the 2.x branch. Discussion ---------- [StimulusBundle/TwigComponent] Fix "use_yield" to "true" deprecation notice in CI | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Issues | | License | MIT Only this one remains (in StimulusBundle), but I can't find a direct implementation related to the `Environment` in that test. Maybe also related to symfony/symfony#53805 or thoughts anyone? ``` 1x: Since twig/twig 3.9.0: Not setting "use_yield" to "true" is deprecated. 1x in StimulusControllerLoaderFunctionalTest::testFullApplicationLoad from Symfony\UX\StimulusBundle\Tests\AssetMapper ``` Commits ------- 1dbb7e0 [StimulusBundle] Set "use_yield" option to fix deprecation message
2 parents 6b6c57c + 1dbb7e0 commit 33c66f3

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

‎src/StimulusBundle/src/Helper/StimulusHelper.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ final class StimulusHelper
2727
public function __construct(?Environment $twig)
2828
{
2929
// Twig needed just for its escaping mechanism
30-
$this->twig = $twig ?? new Environment(new ArrayLoader());
30+
$this->twig = $twig ?? new Environment(new ArrayLoader(), [
31+
'use_yield' => true,
32+
]);
3133
}
3234

3335
public function createStimulusAttributes(): StimulusAttributes

‎src/StimulusBundle/tests/Dto/StimulusAttributesTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ final class StimulusAttributesTest extends TestCase
2424

2525
protected function setUp(): void
2626
{
27-
$this->stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
27+
$this->stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
28+
'use_yield' => true,
29+
]));
2830
}
2931

3032
public function testAddAction(): void

‎src/TwigComponent/tests/Unit/ComponentAttributesTest.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,9 @@ public function testCanAddStimulusControllerViaStimulusAttributes(): void
133133
'data-live-data-value' => '{}',
134134
]);
135135

136-
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
136+
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
137+
'use_yield' => true,
138+
]));
137139
$stimulusAttributes->addController('foo', ['name' => 'ryan', 'some_array' => ['a', 'b']]);
138140
$attributes = $attributes->defaults($stimulusAttributes);
139141

@@ -158,7 +160,9 @@ public function testCanAddStimulusActionViaStimulusAttributes(): void
158160
'data-action' => 'live#foo',
159161
]);
160162

161-
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader()));
163+
$stimulusAttributes = new StimulusAttributes(new Environment(new ArrayLoader(), [
164+
'use_yield' => true,
165+
]));
162166
$stimulusAttributes->addAction('foo', 'barMethod');
163167
$attributes = $attributes->defaults([...$stimulusAttributes]);
164168

0 commit comments

Comments
 (0)
0