[Finder] Described "use natural sort" option #9671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-splitter
pushed a commit
to symfony/finder
that referenced
this pull request
May 30, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Finder] added "use natural sort" option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26930 | License | MIT | Doc PR | symfony/symfony-docs#9671 Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see #26930 for details). Commits ------- e697c7d272 [Finder] added "use natural sort" option
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
May 30, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Finder] added "use natural sort" option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26930 | License | MIT | Doc PR | symfony/symfony-docs#9671 Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see #26930 for details). Commits ------- e697c7d [Finder] added "use natural sort" option
Looks like code has been merged. |
javiereguiluz
approved these changes
Jun 1, 2018
There was a problem hiding this comment.
@vyshkant thanks for providing these docs. I loved that you made it so concise ... but to avoid confusion, I expanded the explanation a bit to show an example. Thanks!
|
And this is now merged! The first merge for Symfony 4.2 🎉 @vyshkant congrats on your first Symfony Docs contribution too! |
javiereguiluz
added a commit
that referenced
this pull request
Jun 1, 2018
…aviereguiluz) This PR was merged into the master branch. Discussion ---------- [Finder] Described "use natural sort" option Added description for new `$useNaturalSort` option of `Finder::sortByName()` method. Commits ------- 9649800 Expanded the explanation a bit 0d38d1b [Finder] Described "use natural sort" option
joshtrichards
pushed a commit
to joshtrichards/symfony-finder
that referenced
this pull request
Apr 26, 2024
This PR was merged into the 4.2-dev branch. Discussion ---------- [Finder] added "use natural sort" option | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26930 | License | MIT | Doc PR | symfony/symfony-docs#9671 Added `$useNaturalSort` optional argument to `Finder::sortByName()` method. If it is specified and equals to `true`, ["natural sort order" algorithm](https://en.wikipedia.org/wiki/Natural_sort_order) will be applied, which means that `strnatcmp` function will be used instead of `strcmp` (see #26930 for details). Commits ------- 16aff97 [Finder] added "use natural sort" option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description for new
$useNaturalSortoption ofFinder::sortByName()method.