8000 Add constructor call to the "Getting Services from the Service Container" section by vekien · Pull Request #8849 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add constructor call to the "Getting Services from the Service Container" section #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add constructor call to the "Getting Services from the Service Container" section #8849

wants to merge 1 commit into from

Conversation

vekien
Copy link
Contributor
@vekien vekien commented Dec 7, 2017

Parent constructor call is required when using auto-wired services in a command constructor, without it you will receive the error:

There are no commands defined in the "app" namespace.

Some discussion of what I ran into: #8843

@vekien
Update console.rst
0926a0d 
Parent constructor call is required when using auto-wired services in a command constructor, without it you will receive the error:

```
There are no commands defined in the "app" namespace.
```
@xabbuh
Copy link
Member
xabbuh commented Dec 8, 2017 •
edited
Loading

I think we should merge this PR into the 2.7 branch. Calling the parent constructor should happen there too.

Looks like we only added the example constructor in 3.4 docs.

@xabbuh xabbuh added this to the 2.7 milestone Dec 8, 2017
@xabbuh xabbuh modified the milestones: 2.7, 3.4 Dec 8, 2017
@xabbuh xabbuh mentioned this pull request Dec 10, 2017
Closed
@weaverryan
Copy link
Member
weaverryan 8000 commented Dec 13, 2017

Great fix. Thank you Josh!

weaverryan added a commit that referenced this pull request Dec 13, 2017
@weaverryan
bug #8849 Add constructor call to the "Getting Services from the Serv…
981c211 
…ice Container" section (viion)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #8849).

Discussion
----------

Add constructor call to the "Getting Services from the Service Container" section

Parent constructor call is required when using auto-wired services in a command constructor, without it you will receive the error:

```
There are no commands defined in the "app" namespace.
```

Some discussion of what I ran into: #8843

Commits
-------

88fd7a7 Update console.rst
@weaverryan weaverryan closed this Dec 13, 2017
@javiereguiluz javiereguiluz mentioned this pull request Jan 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@vekien @xabbuh @weaverryan @javiereguiluz @carsonbot
0