Fixing serializer config - much is now done automatically #8710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Nov 22, 2017
serializer.rst
Outdated
| .. configuration-block:: | ||
|
|
||
| .. code-block:: yaml | ||
| Configruing the Metadata Cache |
xabbuh
reviewed
Nov 22, 2017
| ), | ||
| )); | ||
| The metadata for the serializer is automatically cached. To configure the cache, | ||
| configure the ``framework.cache.pools`` key in ``config/packages/framework.yaml``. |
There was a problem hiding this comment.
Can't we link to another document here?
There was a problem hiding this comment.
Ha! I'm happy you said that. No, there is no better link yet, because we're missing some cache docs! When I hit this, I already created #8711 and linked back to this, so we can improve it later :)
weaverryan
added a commit
that referenced
this pull request
Nov 24, 2017
… (weaverryan) This PR was squashed before being merged into the 4.0 branch (closes #8710). Discussion ---------- Fixing serializer config - much is now done automatically ping @javiereguiluz. The following is done automatically in 3.3 and higher: * serializer is automatically enabled when the component is present (when not using the full stack SE) * serializer annotations is automatically enabled when annotations is present * caching is handled by another system, and is enabled by default This should be merged into 4.0, because it's the only time that not using the full stack is standard... so effectively it only affects 4.0. Also, viva Flex and the new systems! Look how much config is removed :) Commits ------- 8634e40 typo cb31900 Fixing serializer config - much is now done automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @javiereguiluz. The following is done automatically in 3.3 and higher:
This should be merged into 4.0, because it's the only time that not using the full stack is standard... so effectively it only affects 4.0.
Also, viva Flex and the new systems! Look how much config is removed :)