8000 Stop using the deprecated "serializer.mapping.cache.apc" service by javiereguiluz · Pull Request #8133 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Stop using the deprecated "serializer.mapping.cache.apc" service #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Stop using the deprecated "serializer.mapping.cache.apc" service #8133

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7282.

xabbuh
xabbuh reviewed Jul 9, 2017
View reviewed changes
serializer.rst Outdated
),
));

.. versionadded:: 3.1
The ``serializer.mapping.cache.doctrine.apc`` service was introduced in 3.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The serializer.mapping.cache.doctrine.apc service is now also deprecated since Symfony 3.2 (see symfony/symfony#19236).

@xabbuh
Copy link
Member
xabbuh commented Jul 9, 2017

We should instead drop the framework.serializer.cache config option entirely here. In this case, the FrameworkBundle will decorate the ClassMetadataFactory with an instance of CacheClassMetadataFactory which leverages the already installed and preconfigured cache configuration (i.e. using APCu when present).

@xabbuh
Copy link
Member
xabbuh commented Jul 9, 2017

By the way, this option was also deprecated in Symfony 3.1 (see symfony/symfony#18630).

@xabbuh
Copy link
Member
xabbuh commented Jul 9, 2017

changelog fixed accordingly in symfony/symfony@b033e79

@javiereguiluz
Copy link
Member Author

thanks for the review and the explanation. This should be fixed now.

xabbuh
xabbuh reviewed Jul 10, 2017
View reviewed changes
serializer.rst
@@ -223,7 +222,7 @@ A service leveraging `APCu`_ (and APC for PHP < 5.5) is built-in.
framework:
# ...
serializer:
cache: serializer.mapping.cache.apc
cache: id.of.my.own.cache.service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the framework.serializer.cache option we should explain to configure the cache.serializer (which defaults to cache.system) service through the framework.cache.pools option.

@HeahDude HeahDude added this to the 3.2 milestone Jul 29, 2017
@javiereguiluz
Copy link
Member Author

Closing because I don't understand this part of Symfony well enough. Another person can take over this PR and finish it. Thanks!

@javiereguiluz javiereguiluz mentioned this pull request Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Serializer Status: Needs Work
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @xabbuh @ 3355 HeahDude @carsonbot
0