Fixed the explanation about PHPUnit event listeners in PHPUnitBridge #8127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what causes the linked issue, but the listener is registered automatically, here: |
|
@nicolas-grekas That only happens when you use the |
|
Indeed |
|
@javiereguiluz I think we can point it out that you only need to adapt your config if you do not want to make use of the wrapper script. |
|
Thanks for your help and comments. I've reworded this. |
xabbuh
approved these changes
Jul 10, 2017
nicolas-grekas
approved these changes
Jul 10, 2017
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Jul 11, 2017
…PUnitBridge (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #8127). Discussion ---------- Fixed the explanation about PHPUnit event listeners in PHPUnitBridge This fixes #7411. @nicolas-grekas if you have some time, please review this change. Thanks! Commits ------- 29c830b Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7411.
@nicolas-grekas if you have some time, please review this change. Thanks!