8000 Fixed the explanation about PHPUnit event listeners in PHPUnitBridge by javiereguiluz · Pull Request #8127 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Fixed th 8000 e explanation about PHPUnit event listeners in PHPUnitBridge #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed the explanation about PHPUnit event listeners in PHPUnitBridge #8127

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #7411.

@nicolas-grekas if you have some time, please review this change. Thanks!

@nicolas-grekas
Copy link
Member
nicolas-grekas commented Jul 6, 2017 •
edited
Loading

I don't know what causes the linked issue, but the listener is registered automatically, here:
https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/PhpUnit/TextUI/TestRunner.php

@xabbuh
Copy link
Member
xabbuh commented Jul 9, 2017

@nicolas-grekas That only happens when you use the simple-phpunit wrapper script but not when using PHPUnit directly, right?

@nicolas-grekas
Copy link
Member

Indeed

@xabbuh
Copy link
Member
xabbuh commented Jul 9, 2017

@javiereguiluz I think we can point it out that you only need to adapt your config if you do not want to make use of the wrapper script.

@javiereguiluz
Copy link
Member Author

Thanks for your help and comments. I've reworded this.

@xabbuh
Copy link
Member
xabbuh commented Jul 11, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Jul 11, 2017
@xabbuh
minor #8127 Fixed the explanation about PHPUnit event listeners in PH…
9464212 
…PUnitBridge (javiereguiluz)

This PR was squashed before being merged into the 2.7 branch (closes #8127).

Discussion
----------

Fixed the explanation about PHPUnit event listeners in PHPUnitBridge

This fixes #7411.

@nicolas-grekas if you have some time, please review this change. Thanks!

Commits
-------

29c830b Fixed the explanation about PHPUnit event listeners in PHPUnitBridge
@xabbuh xabbuh closed this Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiereguiluz @nicolas-grekas @xabbuh @carsonbot
0