[FrameworkBundle] Add some doc on missing options of framework bundle configuration #8061
Conversation
| use_strict_mode | ||
| ............... | ||
|
|
||
| **type**: ``boolean`` **default**: ``0`` |
There was a problem hiding this comment.
the default value should be false
There was a problem hiding this comment.
I took the PHP default value. More accurate IMO. But I can change if you want.
There was a problem hiding this comment.
since this is a boolean node having 0 will cause more troubles so I would indeed change it :)
|
|
||
| **type**: ``boolean`` **default**: ``0`` | ||
|
|
||
| This specifies whether the module will use strict session id mode. If this mode |
| **type**: ``boolean`` **default**: ``0`` | ||
|
|
||
| This specifies whether the module will use strict session id mode. If this mode | ||
| is enabled, the module does not accept uninitialized session ID. If |
|
|
||
| This specifies whether the module will use strict session id mode. If this mode | ||
| is enabled, the module does not accept uninitialized session ID. If | ||
| uninitialized session ID is sent from browser, new session ID is sent to |
There was a problem hiding this comment.
[...] from the browser, a new session ID is generated.
| metadata_update_threshold | ||
| ......................... | ||
|
|
||
| This is how many seconds to wait between 2 session metadata updates, it will |
There was a problem hiding this comment.
And I would split this into two sentences: "[...] updates. It will [...]"
1fd2823 to
0230482
Compare
|
@xabbuh fixed :). Thanks. |
|
|
||
| **type**: ``boolean`` **default**: ``false`` | ||
|
|
||
| This specifies whether the module will use the strict session id mode. If this |
There was a problem hiding this comment.
I don't know the meaning of "the module" in this context.
| @@ -855,6 +868,18 @@ setting the value to ``null``: | |||
| ), | |||
| )); | |||
|
|
|||
| metadata_update_threshold | |||
| ......................... | |||
|
|
|||
There was a problem hiding this comment.
Here we are missing the data type and its default value.
| This is how many seconds to wait between two session metadata updates. It will | ||
| also prevent the session handler to write if the session has not changed. | ||
|
|
||
|
|
There was a problem hiding this comment.
This extra blank line can be removed.
0230482 to
246fea2
Compare
|
@javiereguiluz everything fixed, I also changed the base branch to 2.7. |
|
Status: Needs Review |
|
Thank you @Nek-. |
…ework bundle configuration (Nek-) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Add some doc on missing options of framework bundle configuration This is the missing documentation following this commit : symfony/symfony@ac9a527 It also adds a part for the missing `metadata_update_threshold` option. Commits ------- 246fea2 Add some doc on missing options of framework bundle configuration
This is the missing documentation following this commit : symfony/symfony@ac9a527
It also adds a part for the missing
metadata_update_thresholdoption.