Removed tip that was meant for the 2.x versions #7564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
HeahDude
approved these changes
Mar 2, 2017
|
@HeahDude it should be 3.1, this functionality was already removed in 3.0 thus makes no sense to keep it in 3.1 but remove it in 3.2 (or am I missing something?) |
|
@iltar 3.1 reached end-of-maintenance by the end of January. That's the time we stopped merging PRs into the |
|
Ah okay, I thought it lasted until July, according to the checker. Missed the part where this is only security atm.
|
|
Thank you @iltar. |
xabbuh
added a commit
that referenced
this pull request
Mar 3, 2017
This PR was merged into the 3.2 branch. Discussion ---------- Removed tip that was meant for the 2.x versions `getRequest()` was removed from the Controller class back in 3.0 already. I could not find a reference on this page to `getRequest` either way so I think it's safe to remove this tip completely. Commits ------- 11f259d Removed tip that was meant for the 2.x versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRequest()was removed from the Controller class back in 3.0 already. I could not find a reference on this page togetRequesteither way so I think it's safe to remove this tip completely.