Fix invalid ProgressBar message examples#7251
Merged
xabbuh merged 3 commits intosymfony:2.7from Jan 24, 2017
Jean85:patch-3
Merged
Fix invalid ProgressBar message examples#7251xabbuh merged 3 commits intosymfony:2.7from Jean85:patch-3
xabbuh merged 3 commits intosymfony:2.7from
Jean85:patch-3
Conversation
This fixes #6544
xabbuh
reviewed
Dec 13, 2016
| placeholder, but if you need more than one, you have just to define your own:: | ||
|
|
||
| $progressBar = new ProgressBar($output, 100); | ||
| $progressBar->setFormatDefinition('custom', ' %current%/%max% -- %message% %filename%'); |
Member
There was a problem hiding this comment.
I think we should describe which placeholders one can use here.
Contributor
Author
There was a problem hiding this comment.
What do you mean? Something like
[...] but if you need more than one, you have just to define your own; in the example below, we added the
messageandfilenameplaceholders:
is enough?
Member
|
I've reworded some contents and added more examples. Ready for a new review. Thanks! |
Contributor
Author
|
LGTM! 👍 |
Member
|
Thank you @Jean85. |
xabbuh
added a commit
that referenced
this pull request
Jan 24, 2017
…guiluz) This PR was merged into the 2.7 branch. Discussion ---------- Fix invalid ProgressBar message examples This fixes #6544. I've removed the confusing bits at the top, where the message placeholder is mentioned, and changed the last part, making the example more meaningful. Commits ------- da7fd2d Reworded some explanations and expanded examples 89a2843 Fix explanation of custom placeholder 771f952 Fix invalid ProgressBar message examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #6544.
I've removed the confusing bits at the top, where the message placeholder is mentioned, and changed the last part, making the example more meaningful.