8000 configure CSRF protection under framework.form by xabbuh · Pull Request #5855 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

configure CSRF protection under framework.form #5855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

configure CSRF protection under framework.form #5855

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Nov 2, 2015
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets symfony/symfony#9252

@stof
Copy link
Member
stof commented Nov 2, 2015

This looks wrong to me. the CSRF layer is available outside the form layer since Symfony 2.4+

@xabbuh
Copy link
Member Author
xabbuh commented Nov 3, 2015

@stof But it's deprecated: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L48-L55

@javiereguiluz
Copy link
Member

I think this change is correct. This is only about adding CSRF automatically to forms or not. But you can deal with the CSRK tokesn yourself outside the forms and without considering this config option.

@stof
Copy link
Member
stof commented Nov 5, 2015

@xabbuh you are confusing enabling the CSRF system and configuring the field_name for its integration in forms

@xabbuh
Copy link
Member Author
xabbuh commented Nov 5, 2015

@stof You are probably right now that I look at this again. Though we removed this option entirely in symfony/symfony#15695. I guess we need to fix that and also revert symfony/symfony-standard#879 then, right?

@wouterj
Copy link
Member
wouterj commented Nov 8, 2015

So this can be closed?

@xabbuh
Copy link
Member Author
xabbuh commented Nov 9, 2015

I don't think so. We first have to agree if we revert the code change or if we update the documentation.

@wouterj wouterj mentioned this pull request Nov 9, 2015
Closed
@wouterj
Copy link
Member
wouterj commented Nov 11, 2015

Code has been reverted

@wouterj wouterj closed this Nov 11, 2015
@xabbuh xabbuh deleted the symfony-standard-879 branch November 11, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @stof @javiereguiluz @wouterj
8F
0