[DependencyInjection] Add documentation about service decoration #3753

romainneutron · 2014-04-03T13:09:14Z

wouterj · 2014-04-03T14:03:08Z

components/dependency_injection/advanced.rst

@@ -185,3 +185,79 @@ the service itself gets loaded. To do so, you can use the ``file`` directive.

 Notice that Symfony will internally call the PHP statement ``require_once``,
 which means that your file will be included only once per request.
+
+Decorating services


Decorating Services

romainneutron · 2014-04-03T14:47:29Z

wouterj · 2014-04-03T15:25:45Z

romainneutron · 2014-04-03T15:54:21Z

stof · 2014-04-03T16:03:19Z

stof · 2014-04-03T16:18:25Z

romainneutron · 2014-04-04T08:59:16Z

cordoval · 2014-04-04T09:01:21Z

components/dependency_injection/advanced.rst

+
+    $container->register('foo', 'stdClass');
+
+    // this is going to remove the old definition with the new one


and replace it with ...

romainneutron · 2014-04-05T11:06:32Z

xabbuh · 2014-04-06T09:23:25Z

components/dependency_injection/advanced.rst

+
+    .. code-block:: php
+
+        $container->register('foo', 'stdClass');


Ist this necessary for this example? We don't have it in either the YAML or XML configuration.

romainneutron · 2014-04-10T10:02:40Z

wouterj · 2014-04-10T10:58:38Z

components/dependency_injection/advanced.rst

+         public: false
+         class: stdClass
+         decorates: foo
+         arguments: [ '@bar.inner' ]


you should use double quotes for consistency. And there should be no spaces inside [], only inside {}

romainneutron · 2014-04-10T13:22:49Z

xabbuh · 2014-04-15T16:45:41Z

weaverryan · 2014-04-28T22:43:17Z

components/dependency_injection/advanced.rst

+
+    // this is going to replace the old definition with the new one
+    // old definition is lost
+    $container->register('foo', 'stdClass');


Maybe we should change the class of 8000 the first or second one? Or just invent a class (other than stdClass)? I didn't realize at first that the first part was the original service and the second was the replacement - I thought maybe you had pasted twice :).

@movetodevnull

wouterj · 2014-05-21T09:38:04Z

romainneutron · 2014-05-21T12:11:01Z

weaverryan · 2014-05-29T12:51:17Z

docteurklein · 2014-09-11T11:55:04Z

components/dependency_injection/advanced.rst

+renaming ``foo`` to ``bar.inner``.
+By convention, the old ``foo`` service is going to be renamed ``bar.inner``,
+so you can inject it into your new service.
+


foo and bar are sooo confusing! Wouldn't it be better to use a real world example, let's say a router ?

We would have router, router.inner and custom_router f.e.

Yes, in fact, why not use a real service from the framework? Sure, this is the components, but any service we choose here will be "invented", so why not use on that's a real service somewhere.

@Baptouuuu

wouterj reviewed Apr 3, 2014
View reviewed changes

cordoval reviewed Apr 4, 2014
View reviewed changes

xabbuh reviewed Apr 6, 2014
View reviewed changes

wouterj reviewed Apr 10, 2014
View reviewed changes

xabbuh mentioned this pull request Apr 15, 2014

[Components][DependencyInjection] add note about a use case that requires to compile the container #3804

Merged

weaverryan reviewed Apr 28, 2014
View reviewed changes

[DependencyInjection] Add documentation about service decoration

578d2e2

weaverryan closed this in 4fd1b49 May 29, 2014

docteurklein reviewed Sep 11, 2014
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] Add documentation about service decoration #3753

[DependencyInjection] Add documentation about service decoration #3753

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Q	A
Doc fix?	yes
New docs?	yes (symfony/symfony#10600)
Applies to	2.5+
Fixed tickets	#3745

Uh oh!

[DependencyInjection] Add documentation about service decoration #3753

[DependencyInjection] Add documentation about service decoration #3753

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!