Updated the docs for the new way to render partials/ESI/HInclude #2121
Conversation
| +----------------------------------------------------+--------------------------------------------------------------------------------------------+ | ||
| | ``render_hinclude(controller('B:C:a', {params}))`` | This will generates an Hinclude tag for the given controller or URL. | | ||
| | ``render_hinclude(url('route', {params}))`` | For more information, see :ref:`templating-embedding-controller`. | | ||
| | ``render_hinclude(path('route', {params}))`` | | |
There was a problem hiding this comment.
you should document the function only, with its signature, so that people can see their name to use named arguments IMO.
There was a problem hiding this comment.
@wouterj the way the form functions are implemented means that the named arguments don't work with them (they are using custom nodes, so they would have to implement the support in these nodes). On the other hand, these functions are using the Twig built-in nodes, so they support named argument.
So for forms, using the right argument is impossible (as there is not even such names as it does not map directly to a function but processes the arguments IIRC) whereas it adds some value here
Updated the docs for the new way to render partials/ESI/HInclude
|
Hi guys! I've merged this in - @fabpot did a really good job catching all the changes - I double-checked things to be sure. So, I think the existing documentation is in good shape from an accuracy standpoint. I've also added #2129 about documenting the content rendering system in more detail. If anyone spots any other missing spots or error in my commit, please let me know! Thanks! |
This is probably just a first step as I think that the new content rendering mechanism can probably be documented in one centralized place where all options are documented.
see symfony/symfony#6459