8000 [Form] Update FormEvents Data and Form Data description by alamirault · Pull Request #18934 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Form] Update FormEvents Data and Form Data description #18934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alamirault
Copy link
Contributor

Fix #11193

FormEvent has 2 value: data and the form which has modelData, normData and viewData.

This PR document what is in FormEvent->data and fix FormEvents::SUBMIT description

@carsonbot carsonbot added this to the 5.4 milestone Sep 27, 2023
Data Type Value
=============== ===================================================================================
Model data Same as in ``FormEvents::POST_SET_DATA``
Normalized data Data from the request reverse-transformed from the request using a view transformer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reported by the issue. Indeed this value is not yet in $event->getForm()->getNormData() but it's given in $event->getData()

@carsonbot carsonbot changed the title Update FormEvents Data and Form Data description [Form] Update FormEvents Data and Form Data description Oct 5, 2023
@javiereguiluz
Copy link
Member

Thank you Antoine.

@javiereguiluz javiereguiluz merged commit 402a073 into symfony:5.4 Oct 5, 2023
@alamirault alamirault deleted the feature/11193-wrong-form-event-description branch October 8, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0